Public bug reported:

[Impact]
Due to a hardcoded version string in debian/rules, new versions of the ksh 
package can cause Launchpad to break when uploading:

override_dh_gencontrol:
        dh_gencontrol --package=ksh93u+m
        dh_gencontrol --package=ksh -- -v20240113

This has been fixed in Debian as an NMU, by appending DEB_VERSION to the
hardcoded version string:

override_dh_gencontrol:
        dh_gencontrol --package=ksh93u+m
        dh_gencontrol --package=ksh -- -v20240113-$(DEB_VERSION)

[Test Plan]
This should be trivial to test and validate, as any binary builds of ksh93u+m 
will generate a ksh with the same version strings (despite different changelog 
versions).

$ dpkg-buildpackage -I -i -nc -d
...
$ ls ../ksh_*deb
../ksh_20240113_all.deb

After including DEB_VERSION to the version string:
$ ls ../ksh_*deb
../ksh_20240113-1.0.8-1ubuntu1_all.deb

[Where problems could occur]
Although this is a simple version change to the transitional ksh package, we'll 
need to include pkg-info.mk. This is also a fairly low-priority fix, as the 
issue will only reproduce when updating the ksh package.
Given the original fix for Debian has been uploaded as an NMU, we'll have to be 
extra careful on any future syncs to not re-introduce breakage.

** Affects: ksh93u+m (Ubuntu)
     Importance: Undecided
         Status: Fix Released

** Affects: ksh93u+m (Ubuntu Jammy)
     Importance: Low
     Assignee: Heitor Alves de Siqueira (halves)
         Status: In Progress

** Affects: ksh93u+m (Ubuntu Noble)
     Importance: Low
     Assignee: Heitor Alves de Siqueira (halves)
         Status: In Progress

** Affects: ksh93u+m (Ubuntu Plucky)
     Importance: Undecided
         Status: Fix Released

** Affects: ksh93u+m (Ubuntu Questing)
     Importance: Undecided
         Status: Fix Released

** Description changed:

  [Impact]
  Due to a hardcoded version string in debian/rules, new versions of the ksh 
package can cause Launchpad to break when uploading:
  
  override_dh_gencontrol:
-         dh_gencontrol --package=ksh93u+m
-         dh_gencontrol --package=ksh -- -v20240113
+         dh_gencontrol --package=ksh93u+m
+         dh_gencontrol --package=ksh -- -v20240113
  
  This has been fixed in Debian as an NMU, by appending DEB_VERSION to the
- hardcoded version string.
+ hardcoded version string:
+ 
+ override_dh_gencontrol:
+         dh_gencontrol --package=ksh93u+m
+         dh_gencontrol --package=ksh -- -v20240113-$(DEB_VERSION)
  
  [Test Plan]
  This should be trivial to test and validate, as any binary builds of ksh93u+m 
will generate a ksh with the same version strings (despite different changelog 
versions).
  
  $ dpkg-buildpackage -I -i -nc -d
  ...
  $ ls ../ksh_*deb
  ../ksh_20240113_all.deb
  
  After including DEB_VERSION to the version string:
  $ ls ../ksh_*deb
  ../ksh_20240113-1.0.8-1ubuntu1_all.deb
  
  [Where problems could occur]
  Although this is a simple version change to the transitional ksh package, 
we'll need to include pkg-info.mk. This is also a fairly low-priority fix, as 
the issue will only reproduce when updating the ksh package.
  Given the original fix for Debian has been uploaded as an NMU, we'll have to 
be extra careful on any future syncs to not re-introduce breakage.

** Changed in: ksh93u+m (Ubuntu)
       Status: New => Fix Released

** Also affects: ksh93u+m (Ubuntu Plucky)
   Importance: Undecided
       Status: New

** Also affects: ksh93u+m (Ubuntu Questing)
   Importance: Undecided
       Status: Fix Released

** Also affects: ksh93u+m (Ubuntu Noble)
   Importance: Undecided
       Status: New

** Also affects: ksh93u+m (Ubuntu Jammy)
   Importance: Undecided
       Status: New

** Changed in: ksh93u+m (Ubuntu Plucky)
       Status: New => Fix Released

** Changed in: ksh93u+m (Ubuntu Noble)
       Status: New => In Progress

** Changed in: ksh93u+m (Ubuntu Jammy)
       Status: New => In Progress

** Changed in: ksh93u+m (Ubuntu Jammy)
   Importance: Undecided => Low

** Changed in: ksh93u+m (Ubuntu Noble)
   Importance: Undecided => Low

** Changed in: ksh93u+m (Ubuntu Jammy)
     Assignee: (unassigned) => Heitor Alves de Siqueira (halves)

** Changed in: ksh93u+m (Ubuntu Noble)
     Assignee: (unassigned) => Heitor Alves de Siqueira (halves)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2117103

Title:
  Hardcoded version in debian/rules breaks new uploads

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ksh93u+m/+bug/2117103/+subscriptions


-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to