Public bug reported:
The debian/licensing/bin/check_image_licenses script has some problems which
need to be fixed:
- Some images being checked are actually not images, but fake strings used in
tests; those don't need to be checked
- Some regexes are not extracting the images from files correctly, e.g. lines
171-174:
for data in $(grep -E '(png|gif);base64' $file_containing_images \
| sed -r
"s|.*[\"'(](data:image/[^;]*;base64[^\"')]*)[\"')].*|\1\n|g" \
| sed -r 's|.*;base64,||' \
| sort -u)
Are producing invalid output, like "=>", as images to be checked
- Regeneration of the image-checksums.dcf file needs to be double checked
- The actual loop which lists checksums for validation can be improved
performance and correctness wise, e.g. line 349:
for checksum in $(echo $checksum_from_filesystem
$checksum_from_checksum_file | tr ' ' '\n' | sort -u)
** Affects: symfony (Ubuntu)
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2119549
Title:
check_image_licenses script is checking invalid images
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/symfony/+bug/2119549/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
