Review for Source Package: loupe [Summary]
Loupe is the new image viewer for GNOME. The package looks good. Any problems regard testing, but the explanation provided in bug description is sufficient. a) Tests at run time are trivial but explanation sufficient (heavy testing of glycin and gtk4) b) No autopkgtest because this package requires manual testing. The testplan can be found at https://wiki.ubuntu.com/DesktopTeam/TestPlans/Loupe. One important bug reported in debian that affects upstream too, listed as recommended TODO. MIR team ACK under the constraint to resolve the below listed required TODOs and as much as possible having a look at the recommended TODOs. This does need a security review, so I'll assign ubuntu-security List of specific binary packages to be promoted to main: loupe Specific binary packages built, but NOT to be promoted to main: <None> Notes: Recommended TODOs: 1. Please address if possible the 1 important bug in debian and upstream. Debian bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1092943 Upstream bug: https://gitlab.gnome.org/GNOME/loupe/-/issues/139 - The package has a team bug subscriber. [Rationale, Duplication and Ownership] There is another package in main providing the same functionality, but loupe it's the new default image viewer for GNOME. Ubuntu Desktop team is committed to own long term maintenance of this package. The rationale given in the report seems valid and useful for Ubuntu. [Dependencies] OK: - no other Dependencies to MIR due to this - no -dev/-debug/-doc packages that need exclusion - No dependencies in main that are only superficially tested requiring more tests now. Problems: None [Embedded sources and static linking] OK: - Rust package that has all dependencies vendored. It does neither have *Built-Using (after build). Nor does the build log indicate built-in sources that are missed to be reported as Built-Using. - rust package using dh_cargo (dh ... --buildsystem cargo) - Includes vendored code, the package has documented how to refresh this code at debian/README.source. Problems: None [Security] OK: - history of CVEs does not look concerning - does not run a daemon as root - does not use webkit1,2 - does not use lib*v8 directly - does not expose any external endpoint (port/socket/... or similar) - does not process arbitrary web content - does not use centralized online accounts - does not integrate arbitrary javascript into the desktop - does not deal with system authentication (eg, pam), etc) - does not deal with security attestation (secure boot, tpm, signatures) - does not deal with cryptography (en-/decryption, certificates, signing, ...) Problems: - does parse data formats (files [images, video, audio, xml, json, asn.1], network packets, structures, ...) from an untrusted source. [Common blockers] OK: - does have a test suite that runs at build time - test suite fails will fail the build upon error. - does not FTBFS currently - no new python2 dependency Problems: - does not have a non-trivial test suite that runs as autopkgtest [Packaging red flags] OK: - Ubuntu does carry a delta, but it is reasonable and maintenance under control (rust vendoring) - symbols tracking not applicable for this kind of code. - debian/watch is present and looks ok (if needed, e.g. non-native) - Upstream update history is good - Debian/Ubuntu update history is good - the current release is packaged - promoting this does not seem to cause issues for MOTUs that so far maintained the package - no massive Lintian warnings - debian/rules is rather clean - It is not on the lto-disabled list Problems: None [Upstream red flags] OK: - no Errors/warnings during the build - no incautious use of malloc/sprintf (the language has no direct MM) - no use of sudo, gksu, pkexec, or LD_LIBRARY_PATH (usage is OK inside tests) - no use of user 'nobody' outside of tests - no use of setuid / setgid - no dependency on webkit, qtwebkit or libseed - part of the UI, desktop file is ok - translation present Problems: - one important open bugs (crashers, etc) in Debian or Ubuntu: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1092943 https://gitlab.gnome.org/GNOME/loupe/-/issues/139 ** Bug watch added: Debian Bug tracker #1092943 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1092943 ** Bug watch added: gitlab.gnome.org/GNOME/loupe/-/issues #139 https://gitlab.gnome.org/GNOME/loupe/-/issues/139 ** Changed in: loupe (Ubuntu) Assignee: Ioanna Alifieraki (joalif) => (unassigned) ** Changed in: loupe (Ubuntu) Assignee: (unassigned) => Ubuntu Security Team (ubuntu-security) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2115989 Title: [MIR] loupe To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/loupe/+bug/2115989/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
