This generally looks fine to me, but for questing this does require a
feature freeze exception[1].

I did have one question about the debdiff though. Why is this hunk in
libmbim-glib4.symbols necessary?

diff --git a/debian/libmbim-glib4.symbols b/debian/libmbim-glib4.symbols
index db512e3..26b8385 100644
--- a/debian/libmbim-glib4.symbols
+++ b/debian/libmbim-glib4.symbols
@@ -214,8 +216,8 @@ libmbim-glib.so.4 libmbim-glib4 #MINVER#, libmbim-proxy
  mbim_message_command_new@Base 1.10.0
  mbim_message_command_type_get_string@Base 1.10.0
  mbim_message_command_type_get_type@Base 1.10.0
- mbim_message_compal_at_command_query_new@Base 1.31.6
- mbim_message_compal_at_command_response_parse@Base 1.31.6
+ mbim_message_compal_at_command_query_new@Base 1.31.2-0ubuntu4
+ mbim_message_compal_at_command_response_parse@Base 1.31.2-0ubuntu4
  mbim_message_connect_notification_parse@Base 1.10.0
  mbim_message_connect_query_new@Base 1.10.0
  mbim_message_connect_response_parse@Base 1.10.0

It looks wrong to me to change the version in the symbols file.

[1] https://wiki.ubuntu.com/FreezeExceptionProcess

** Changed in: libmbim (Ubuntu)
       Status: New => Incomplete

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2121842

Title:
  [SRU] add Intel mbim service to send AT command on Dell DW5933e

To manage notifications about this bug go to:
https://bugs.launchpad.net/oem-priority/+bug/2121842/+subscriptions


-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to