Thank you for preparing a patch!

We're currently in Beta freeze for Questing, so this can only be
uploaded starting next week. Please re-ping the corresponding patch-
pilot next week.

For now, I can provide you with some review comments for improvement of
the patch:

- debian/changelog: Please use a proper reference to the Launchpad bug so that 
it can be detected by the automation, e.g. (LP: #2121543)
- debian/patches/bug2121543.patch: (nitpick) we usually refer to bugs as 
"lp-2121543-SHORT-DESC.patch", might (or might not) consider renaming the patch 
file, e.g. "lp-2121543-do-not-close-and-reopen-DB.patch"
- kudos: Thanks for adding DEP-3 headers
  => But you're using Author and Origin at the same time. Was the patch created 
by you, or does it originate from upstream? You should delete one or the other 
header.
  => Also, you should add a full URL to the actual upstream patch/commit (if 
merged already), "Origin: upstream: https://...";
  => If it's not yet merged upstream, you should consider adding a "Forwarded: 
..." header, pointing to a full URL where the change has been 
proposed/discussed with the upstream developers.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2121543

Title:
  [SRU] Poor performance of libnss-db on large db files

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libnss-db/+bug/2121543/+subscriptions


-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to