@schopin Great point fellow Simon. The original bug report even mentioned the unencrypted remote as working and as not affected by the bug, so we don't want this patch to have an effect on that.
** Description changed: [ Impact ] - Users are unable to sync files to OneDrive successfully using rclone and receive the error: + Users are unable to sync files to OneDrive successfully using rclone and receive the error: > "Failed to copy: unauthenticated: Unauthenticated" Newer versions include a fix that better complies with the authorization described in the documentation for the OneDrive API. Currently installed versions incorrectly include the Authorization header in the PUT call, which the API mentions can result in the aforementioned error (see https://learn.microsoft.com/en- us/graph/api/driveitem-createuploadsession?view=graph-rest-1.0#remarks). [ Test Plan ] - *Assuming `rclone` is set-up for OneDrive* + *Assuming `rclone` is set-up for OneDrive using both a regular and crypt remote* - 1) Create a directory `temp` in the home directory of your user: - ```shell - mkdir /home/<user>/temp - ``` - - 2) Create a file in that directory: - ```shell - echo Hello > /home/<user>/temp/file - ``` + 1) Create a directory `temp` in the home directory of your user: + ```shell + mkdir /home/<user>/temp + ``` - 3) Sync the directory using `rclone copy`: - ```shell - rclone copy /home/<user>/temp <onedrive_remote>:temp - ``` + 2) Create a file in that directory: + ```shell + echo Hello > /home/<user>/temp/file + ``` + + 3) Sync the directory using `rclone copy` to the crypt remote: + ```shell + rclone copy /home/<user>/temp <onedrive_crypt_remote>:temp + ``` + + 4) Additionally, sync the directory to the regular remote: + ```shell + rclone copy /home/<user>/temp <onedrive_remote>:temp + ``` [ Where problems could occur ] - The SRU candidate patch on Questing (`rclone 1.60.1+dfsg-4ubuntu1`) mainly includes a OneDrive authentication fix and previous patches have been rebuilds to meet golang updates. - As such it is likely that future problems would occur within the OneDrive integration or as issues following changes in golang. + The SRU candidate patch on Questing (`rclone 1.60.1+dfsg-4ubuntu1`) mainly includes a OneDrive authentication fix and previous patches have been rebuilds to meet golang updates. + As such it is likely that future problems would occur within the OneDrive integration or as issues following changes in golang. - More specifically, the changes to the common code introduced by the + More specifically, the changes to the common code introduced by the patch only add new functions and function pointers that are not used by anything other than the final OneDrive patch. [Original Bug] I use Rclone to sync my offsite backups to OneDrive. Up until 07/20/2024 this worked just fine, however now if I try to sync any file that is not a directory, it throws a 'Failed to copy: unauthenticated: Unauthenticated' error on any other file. I tested it with the normal 'onedrive' (unencrypted) remote and I do not have this problem. This issue is not occuring with the latest upstream version 1.67.0. What I expect to happen: A seamless sync between the local file system structure and the 'OneDrive' remote using the 'crypt' remote as an encryption layer. What happened instead: Only directorys get synced, their content and standalone files fail to sync with the error message "Failed to copy: unauthenticated: Unauthenticated" despite the authentication token being set properly. Description: Ubuntu 22.04.4 LTS Release: 22.04 rclone: Installed: 1.53.3-4ubuntu1.22.04.2 Candidate: 1.53.3-4ubuntu1.22.04.2 Version table: *** 1.53.3-4ubuntu1.22.04.2 500 500 http://archive.ubuntu.com/ubuntu jammy-updates/universe amd64 Packages 500 http://security.ubuntu.com/ubuntu jammy-security/universe amd64 Packages 100 /var/lib/dpkg/status 1.53.3-4ubuntu1 500 500 http://archive.ubuntu.com/ubuntu jammy/universe amd64 Packages -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2076021 Title: Rclone on Ubuntu 22.04 is unable to sync crypt remote with OneDrive properly To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/rclone/+bug/2076021/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
