Please resubscribe ubuntu-sponsor once that build failure has been addressed.
Just a couple things on Matthew's review that strike me: > I recommend version schemes like: Take the current package version: 2.10.1-2ubuntu4, then: sssd - 2.10.1-2ubuntu4+<case number or lp bug number>vDATEb1 Don't use the existing package version but rather use your *target* version, and use ~ before your suffix. I'll usually use ~ppa1, as there is tooling out there that will help enforce this. Using the target version is important, because version numbering is often something that people trip up on in SRUs. > Lastly, you can also do a "quilt refresh" on your patches so they match the source code, and no ambiguous fuzz needs to happen in the future. Note it does change from git to the quilt format, but thats okay. Please don't. Gratuitous refreshes make diffs extremely noisy, making it harder for reviewers to focus on the content that actually matters. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2110521 Title: Continue searching other PKCS#11 tokens if certificates are not found To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/sssd/+bug/2110521/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
