I have reviewed ceph 19.2.3-0ubuntu1 for uploading.
* Upstream code
- The diff from the upstream tarball makes sense as pointed out by @mrufell

* Build and test
- The package builds as expected in the PPA both with -proposed enabled and 
just with -updates
- Autopkgtests are passing for the version in the PPA

* Packaging
- Changes to d/control and d/rules make sense and are listed in the changelog
- Kept patches apply correctly, with no fuzz
- d/p/boost-url.patch was changed but it is not mentioned in the changelog. The 
change is adding 'process' to BOOST_COMPONENTS - which is used in one of the 
new patches (questing-boost-fix.patch). As this one targets 'url', it would 
make more sense for this change to be part of the new patch instead. I fixed 
this so the upload is not blocked.
- New patches:
 - d/p/questing-boost-fix.patch: The header specifies this does not need 
forwarding, it makes sense.
 - d/p/pyo3-fix.patch: The Origin metadata points to a pull request; generally 
I would say it's better to point at the commit itself. I took the liberty of 
changing that.
- All removed patches are now part of the upstream code and were correctly 
dropped. No other patches to drop.

* Exception
- FFe aproved by the release team 
(https://bugs.launchpad.net/ubuntu/+source/ceph/+bug/2126446)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2119024

Title:
  [SRU] Squid: Ceph new point release 19.2.3

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/2119024/+subscriptions


-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to