Since you are patching the desktop file, I suggest you ensure that the desktop file validates with the desktop-file-validate tool, found in the desktop-file-utils package. This is the error I get when attempting to validate the desktop file.
sysinfo.desktop: error: value "computer.png" for key "Icon" in group "Desktop Entry" is an icon name with an extension, but there should be no extension as described in the Icon Theme Specification if the value is not an absolute path You can look at the below URL for the specification referred to above for more information. http://standards.freedesktop.org/desktop-entry-spec/latest/ Secondly, you should also include the bug number for this bug in the changelog entry, so that when your package gets uploaded, the bug is closed. The syntax is as follows: LP: #nnnnnn. In this case, it would be LP: #182700 Thirdly, while the code you added to debian/rules does work for applying patches, making use of a patch system like dpatch or quilt, saves a lot of work when it comes to adding, or removing patch support to a package that doesn't already use something like cdbs. Its fine for now, but I would encourage the research of the dpatch and quilt packages, which provide patch systems for building packages. Please re-subscribe ubuntu-universe-sponsors once the above issues have been addressed. ** Changed in: sysinfo (Ubuntu) Assignee: Luke Yelavich (themuso) => (unassigned) Status: In Progress => Incomplete -- Please sponsor sysinfo 0.7ubuntu3 (universe) into Hardy https://bugs.launchpad.net/bugs/182700 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
