i) Ok, so I personally find the patch a bit ugly and would love you sending my critics and/or fixes upstream; especially the remarks about the error message being useless and being sent to stdout instead of stderr. I would feel a bit dirty to bless the addition of such a patch. If it was merged as is in the upstream code base, then I think it needs fixing upstream.
Also, I would be more happy with a slightly longer / more precise explanation on the patch in the changelog (or if you prefer, in the patch header itself); perhaps something like: * New patch, 03-Accept-specific-desktop-file, now use X-AWN-AppletType in AWN applets' .desktop files or output a warning if this field is missing. ii) Concerning the Recommends, indeed Ubuntu doesn't install Recommends by default; to keep the rationale for the bump in some place, and hence to allow us to switch back from Depends to Recommends when Ubuntu installs these by default, I'd suggest being a little more explicit in the changelog: * Promote Recommends to Depends to force installation of awn-manager as Ubuntu doesn't install Recommends by default. (NB: If you open an upstream bug / start a mailing-list discussion for the first point, then probably I'll sponsor an updated package with the proposed changelog tweaks, seeing that the upstream fix is making progress on its own.) -- Various fixes in debian dir https://bugs.launchpad.net/bugs/181635 You received this bug notification because you are a member of Ubuntu Bugs, which is the bug contact for Ubuntu. -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
