Hi Alejandro, 1) Your git repositories are incorrect. OpenStack is special as the OpenStack Team request that all changes are tracked in their own git repositories in lp:~ubuntu-openstack-dev/ubuntu/+source/heat instead of ubuntu/+source/heat:ubuntu/<series>-devel.
Please checkout https://git.launchpad.net/~ubuntu-openstack-dev/ubuntu/+source/heat and make your changes to the correct branch. E.g. plucky is stable/2025.1, noble is stable/2024.1, jammy is stable/yoga. See https://canonical-se-docs.readthedocs-hosted.com/en/latest/se-resources/se-sponsorship/ubuntu-cloud-archive-sru/ for more details. Perhaps talk to Ed and see if any in-between releases like bobcat, antelope need to be fixed as well, or if they can be safely ignored. 2) For debian/changelog entries, I really prefer the structure: * Description of the change. (LP: #2097539). - d/p/lp2097539-1-patch-name.patch - d/p/lp2097539-2-patch-name.patch Etc. E.g. +heat (1:18.0.1-0ubuntu1.3) jammy; urgency=medium + + * Fix stack update when reauth = trusts (LP: #2097539). + - d/p/lp2097539-Fix-stack-update-when-reauthentication_auth_method-t.patch + + -- Alejandro Santoyo <[email protected]> Tue, 16 Sep 2025 08:51:43 +0000 It just matches well used Ubuntu conventions this way. 3) Another convention is to use patch filenames like: lp2097539-patch-name.patch or if there are many patches, number them: lp2097539-1-patch-name.patch lp2097539-2-patch-name.patch It helps at a glance show what patches are debian delta and what are connected to Launchpad bugs. Please change your filename. 4) For the patch itself, you can tidy it up a bit. E.g. remove [PATCH] from the subject line, "Mon Sep 17 00:00:00 2001" from the From line. Usually, we use the "Bug:" tag for upstream bugs, e.g. Bug: https://storyboard.openstack.org/#!/story/2011342 For Ubuntu we use "Bug-Ubuntu:" e.g. Bug-Ubuntu: https://bugs.launchpad.net/bugs/2097539 Otherwise, your patch and SRU template is quite good. I'll have another look once you open up fresh merge requests. Thanks, Matthew -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2097539 Title: Heat stack updates fail when "reauthentication_auth_method=trusts" To manage notifications about this bug go to: https://bugs.launchpad.net/cloud-archive/+bug/2097539/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
