Hm.

1) The patch 0012-Allows-non-standard-OVS-setups.patch introduces a
possible confusion between the python and C code - Python looks for ovs-
vsctl in "/snap/bin/" and "/usr/bin" whereas the C code looks for it in
SNAPBINDIR and PREFIX + "/" + BINDIR + "/". SNAPBINDIR will be #define
to "/snap/bin", but both PREFIX and BINDIR are set from the build
system, and so won't necessarily come out as "/usr/bin".

Is there a reason you didn't go looking in $PATH?

2) The changelog for this made it a bit difficult to review - it is much
easier to review this as a the addition of 0012-Allows-non-standard-OVS-
setups.patch (from the Questing package) plus the test-suite
improvements than as a backport of 1.1.2-7ubuntu3 minus a bunch of
changes.

3) You should have called out the addition of Suggests: systemd-
resolved; either in the changelog or this documentation. That's minor,
because Suggests are weak; this is just for completeness.

I'd like you to verify that (1) isn't going to be an issue; otherwise,
this looks acceptable.

** Changed in: netplan.io (Ubuntu Plucky)
       Status: New => Incomplete

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2127195

Title:
  [SRU] Backport netplan.io 1.1.2-7ubuntu3 to 24.04

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/netplan.io/+bug/2127195/+subscriptions


-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to