Public bug reported:

When an erroneous menu structure is specified via D-Bus, where the top-
level menu contains child items but its "children-display" property is
not set to "submenu", libdbusmenu-gtk outputs a warning message
mentioning a child-display variable:

(waybar:1337): LIBDBUSMENU-GTK-WARNING **: 12:00:00.000: The child-
display variable is set to '(null)' but there's a menu, odd?

The message is found in file libdbusmenu-gtk/client.c in the
process_submenu function, specifically at line 710 at the current
moment:

g_warning("The child-display variable is set to '%s' but there's a menu,
odd?", submenu);

I propose that the message be restructured to be similar to the one in
the new_child function in the same file, where the variable/property
name is placed into single quotes and included from the relevant macro:

g_warning("The property '" DBUSMENU_MENUITEM_PROP_CHILD_DISPLAY "' is
set to '%s' but there's a menu, odd?", submenu);

** Affects: libdbusmenu (Ubuntu)
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2130962

Title:
  "child-display" variable name in warning message should match protocol

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libdbusmenu/+bug/2130962/+subscriptions


-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to