I've reviewed the packaging changes; they mostly look good, I have only a few questions/comments:
The added Build-Depends: liblttng-ust-dev, liblttng-ust1t64, are duplicative; liblttng-ust-dev already Depends on liblttng-ust1t64. Is there a reason for explicitly pulling liblttng-ust1t64 in? The debian/rules change: - extraopts += -DWITH_LTTNG=OFF -DWITH_EMBEDDED=OFF + extraopts += -DWITH_LTTNG=ON -DWITH_EMBEDDED=ON changes both the WITH_LTTNG and WITH_EMBEDDED settings. (This appears to be harmless because WITH_EMBEDDED appears to be an option the build system no longer recognises) Finally, the Noble upload has a weird diff from the other uploads: diff -Nru ceph-19.2.3/debian/patches/snapshot-upgrade-fix.patch ceph-19.2.3/debian/patches/snapshot-upgrade-fix.patch --- ceph-19.2.3/debian/patches/snapshot-upgrade-fix.patch 2025-08-12 03:02:00.000000000 +1000 +++ ceph-19.2.3/debian/patches/snapshot-upgrade-fix.patch 2025-10-01 07:02:28.000000000 +1000 @@ -5,14 +5,15 @@ the right order Reference: https://bugs.launchpad.net/ubuntu/+source/ceph/+bug/2089565 -Origin: vendor -Bug-Ubuntu: https://bugs.launchpad.net/bugs/2089565 --- - diff --git a/src/mds/MDSMap.cc b/src/mds/MDSMap.cc -index cd5cb3a98a..5a68a2ef0b 100644 + src/mds/MDSMap.cc | 120 ++++++++++++++++++++++++++++++++++++++++++++-- + 1 file changed, 116 insertions(+), 4 deletions(-) + +diff --git a/src/mds/MDSMap.cc b/src/mds/MDSMap.cc +index cd5cb3a98a..297f0da50b 100644 --- a/src/mds/MDSMap.cc +++ b/src/mds/MDSMap.cc -@@ -961,11 +961,114 @@ void MDSMap::decode(bufferlist::const_iterator& p) +@@ -961,11 +961,123 @@ void MDSMap::decode(bufferlist::const_iterator& p) } if (ev >= 17) { @@ -94,7 +95,10 @@ + * + * Quincy 17.2.7 has neither of the 2 fields. + */ ++ dout(20) << "ev=" << ev << dendl; ++ + unsigned off = p.get_off(); ++ dout(20) << "off=" << off << dendl; + + /* + * The smallest size is a single decimal digit bal_rank_mask, @@ -108,18 +112,24 @@ + uint8_t byte; + decode(byte, p); + p.seek(off); - -- if (ev >= 18) { -- decode(max_xattr_size, p); ++ ++ dout(20) << "byte=" << static_cast<int>(byte) << dendl; ++ + if (byte < 0x10) { ++ dout(20) << "decoding in the normal squid order" << dendl; ++ + if (ev >= 17) { + decode(max_xattr_size, p); + } -+ + +- if (ev >= 18) { +- decode(max_xattr_size, p); + if (ev >= 18) { + decode(bal_rank_mask, p); + } + } else { ++ dout(20) << "decoding in the squid git snapshot order" << dendl; ++ + if (ev >= 17) { + decode(bal_rank_mask, p); + } However, this is not a change from the status-quo - this is not a diff introduced by this upload. It might be worth working out why the Noble version of this patch is slightly different, though. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2119024 Title: [SRU] Squid: Ceph new point release 19.2.3 To manage notifications about this bug go to: https://bugs.launchpad.net/cloud-archive/+bug/2119024/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
