Hi Michael, Jay and I went through the patchset, and we think its okay. Our previous comments occurred before we had a chance to read the whole patchset.
That said, you missed the following fixes commits: b1e44b4 ixgbe: fix media cage present detection for E610 device 4020659 ixgbe: fix media type detection for E610 device b85936e ixgbe: initialize aci.lock before it's used 316ba68 ixgbe: destroy aci.lock later within ixgbe_remove path They are all in questing 6.17, and the first two are in plucky's 6.14 kernel. I think these are valid fixes and should be added to your pull request. What do you think? If you agree, please do another test build with these applied, make sure it all works and modify your [Fixes] section, and resubmit your pull request. Thanks, Matthew -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2131265 Title: [SRU] ixgbe: Add support for E610 in Noble To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2131265/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
