Thank you for the review A little context: This package was previously packaged by lunarG [1] But the quality was not up to Ubuntu's standards, so I improved it (not enough, yet!).
1. This context is why the changelog contains the previous entries. My opinion is that keeping the history would be better, but what do you think? 2. I'm know excluding CMakeLists.txt and android/ folder throught the d/copyright file. I also excluded one .kra file that was making lintian unhappy. The patch is removed. The package is now a +dfsg one, I adapted the watch file in regards to that. 3. Packages who implement get-orig-source for packages with watch files get extra points `get-origin-source` seems deprecated [1] and "one should try their best to avoid using this target when possible". How can I still get extra points? 4. I suggest not to update to the latest version because it is using a vendored, unreleased, vulkan-headers version. If I want to package it I'll have to vendor vulkan-headers. I would prefer waiting for vulkan- headers to be released, then update debian, ubuntu, and only then update this one. 5. Changelog updated to include the LP bug 6. Description modified in d/control to align with the policy 7. I don't have the mismatched-override of vulkan-profile.hpp using lintian's version from questing. 8. I fixed the desktop file to make it better (and make lintian more happy). The icon is now there, installed from the rules. 9. I removed the runtime dependency to qtbase5-dev which was, indeed, useless. 10. I restricted the architectures to amd64, arm64. 11. the +build1 in the version was only for the ppa upload. I turned it into +ppa1 to make it less confusing. The uploaded version is now 4.02+dfsg-0ubuntu1+ppa3, whose target version would be 4.02+dfsg-0ubuntu1 12. I have removed the Vcs field entirely, as per the review from another package [3]. My current version control is on git.launchpad.net/~antoinelassagne/ubuntu/+source/vulkancapsviewer ubuntu/devel [1] https://packages.lunarg.com/vulkan/1.4.313/pool/main/v/vulkancapsviewer/ [2] https://wiki.debian.org/onlyjob/get-orig-source [3] https://bugs.launchpad.net/ubuntu/+bug/2127243/comments/9 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2127197 Title: [needs-packaging] vulkancapsviewer To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+bug/2127197/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
