I took the benefits from the reviews I got from other packages I worked on to improve the overall quality of this packaging. I've updated it in the archive mentioned above.
The code is also available in https://bugs.launchpad.net/ubuntu/+bug/2127245 There is one thing that I am not sure of. The unvendoring or submodules (spirv-tools, spirv-headers) makes the package not exactly like upstream would want for a given tag. This makes 2 tests (out of 4600+) fail at the moment: - One test is succeeding instead of failing, because the more recent version of the header fixes it. This is actually how upstream fixed the test. - One test fails. I'm not entirely sure how to manage these. I can surely patch the first one (flag it as "should succeed") and the second one (ignore it entirely?). Overall, these tests will be fragile given the unvendoring situation, and time-consuming to debug give the build time of the package. But having tests failing is surely the best indicator of a package not working as it should. Right now I've enabled only half of the tests, to have them pass. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2127245 Title: [needs-packaging] directxshadercompiler To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+bug/2127245/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
