I'll caution that the SRU template could probably do with some work here: The test plan checks that the fundamental change (inclusion of a missing module) has been made, but this isn't actually checking that the fundamental bug (inability to boot from USB) has been fixed. I understand that in plucky's case this is going to be difficult, and also somewhat pointless given plucky won't be seeing a new image. However, in noble's case it would be nice to ensure this actually fixes the issue (even if that does mean building an OS image and flashing it to USB to do so).
The "where things could go wrong" section also needs some work. While it correctly notes this will increase the size of the initramfs, we must also consider what effects this may have. For example, we have had cases where increases in the initramfs size caused boot assets to no longer fit on the boot partition of certain devices, leading to failure to boot on those devices. These risks should at least be mentioned (though if the test plan is updated to actually test the boot, this risk can be noted as being mitigated by the test plan). Nonetheless, the patches look good, so I'm sponsoring them for plucky and noble, but I would recommend the SRU template be updated accordingly. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2126559 Title: [SRU] Missing usb/host/xhci-pci-renesas kernel module in the initramfs To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/initramfs-tools/+bug/2126559/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
