I've started reviewed that package and that library isn't
versioned/doesn't have a soname. It has been reported upstream in 2023
but got no reaction,
https://github.com/lucianodato/libspecbleach/issues/55

https://www.debian.org/doc/debian-policy/ch-sharedlibs.html

The most recent commit is 3 years old

Is that really something we want to see in Ubuntu?


Otherwise some other review comments

* debian/control:

- The .pc has "Requires.private: fftw3f" so the dev binary should
Depends on libfftw3-dev

(minor) - remove the commented line addind a Depends of the dev to
shlibs

(improvement) rather than duplicating the descriptions you could define
it once in the source section and use ${source:Synopsis} and
${source:Extended-Description}


* debian/libspecbleach.dirs

can be removed, the meson install target is creating /usr/lib as part of
installing the library

* lintian-override

> # Special-purpose shared object for which an ABI version is not
meaningful.

can you explain that? either it's a shared library and should have a
soname, or it is a private library and should be installed in its own
subdir and the program using it should be taught to look for it there


* debian/libspecbleach.triggers

the file isn't needed, dh_makeshlibs is creating that one for you

* debian/shlibs.local

should be needed since you have a .symbols which is a better equivalent

** Bug watch added: github.com/lucianodato/libspecbleach/issues #55
   https://github.com/lucianodato/libspecbleach/issues/55

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2136270

Title:
  New package: libspecbleach

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+bug/2136270/+subscriptions


-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to