(In reply to KRosUser from comment #55) > Are you still working on this MR ?
The implementation for the MR is mostly complete. The unit test requirements were unreasonable though, which is why the MR was not accepted. The unit tests are there in the MR, I used compressed data extracted from the Adobe Reader installer for test data. However, the maintainers are requiring self generated data, which would require an implementation of mspatchc, along with tests for that module as well, which is why I say the requirements are unreasonable. I am going to sound critical here, but I do believe the maintainers are unreasonably concerned in this case. Without sounding too accusatory, when I looked into the test data that already existed, it seemed very likely to also have been extracted from something, so I don't see why it's now suddenly an issue. I mean, I get it, I'm just a contributor, and there are risks, but I don't think Wine will succeed in the future with unreasonable concerns like where simple useless extracted snippets of compressed bytes come from that are used for unit tests. Looking at Proton for example, some of the things they are doing is, funny enough, much worse than what is in this PR. Does Valve just has a better legal team? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1111610 Title: Can't install Adobe Reader To manage notifications about this bug go to: https://bugs.launchpad.net/wine/+bug/1111610/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
