Hello, I had a quick look and can give you some improvement tips:
- It's not very clear which package the reviewer shall review. I used the master branch of your repo, and the Resolute upload on your PPA, but unsure it's the latests? There seem to be other packages in the mix, too (onednn, etc.) - You must reference the LP bug number in the changelog. I think the changelog must be clean for the first upload, with only one entry. - You mention that you don't have a manpage yet. You can generate one with help2man for example. See here [1] for an example. - You have a lot of lintian errors. Run lintian -EvIL +pendantic against both the .changes file and the built .deb - There seem to be a few vendored things in there. Not sure it's a blocker for Ubuntu, but listing them in a readme would be helpful. - The copyright file is surprisingly small given the size of the package. I've ran `licensecheck --check '.*' --recursive --deb-machine --lines 0 -- *` to compare, but the result is awful. nYou should double check it, and at least the vendored stuff must be mentioned in the copyright file (if you keep it) - Are you running any of the provided build-time tests? if no, you should probably do so. Either way, you can also add the integration tests as autopkgtests, to harden this package against the rest of the archive. - libumf-dev does not look to be in the archive. I don't see in the sponsorship queue, either. [1]: https://git.launchpad.net/ubuntu/+source/spirv- reflect/tree/debian/rules#n12 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2130186 Title: [needs-packaging] intel-dpcpp To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+bug/2130186/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
