Review for Source Package: python-invoke

[Summary]
MIR team NACK (until the rationale is clarified)

Rest of this section is n/a until that is sorted out

Notes:
Required TODOs:
- #1 - as you identified, it should please get reasonable autopkgtests added
- #2 - please outline why it can't stay a suggests. Extend the case here
       by the reasoning that we should hold against the maintenance effort
       and quality bar it has to pass.

[Rationale, Duplication and Ownership]
Biggest similarity if src:fabric (the older predecessor) which is not in main.
Other languages like ruby rake, do not matter as this is mean to be for the
python use case.
There is no other package in main providing the same functionality/language.

A team is committed to own long term maintenance of this package.

The rationale given in the report is a bit light - not much rationale was given.
"It is needed for paramiko" is all that it mentions. And if we look at that we
see
 paramiko   | 4.0.0-1       | unstable     | source
 paramiko | 3.5.1-3ubuntu1        | resolute        | source

And in the Delta of 3.5.1-3ubuntu1

 - debian/control: Demote python3-invoke from Recommends to Suggests as
   the python-invoke package lacks unit test execution so is not suitable
   for main inclusion

And that isn't a one off, it was like that since 2020.
Why is that no more an option?

I was checking myself and found upstream to say in the 4.0 changelog.
  - moved Invoke requirement to core dependencies, and removed
    paramiko[invoke] from extras

At build time it isn't needed in !notest, at runtime it is still only
a recommends and therefore not strictly needed for anything.

I wondered what paramiko uses it for, and found only `match exec` ssh
config to really require this (this check might be incomplete). Which isn't
a common config option to be used. And those that need it can still install it
from universe as they've done so far.

I guess if there would be a concern that the world breaks without it, it would
be a depends instead of a suggest.
Have you maybe spotted something in 4.x which makes this a much harder
dependency now that I might have missed?
Are there other reasons?

Sorry, but I need to ask - is there a stronger reason than before to need
this now for anything but the maintenance of the delta. I mean if that is
all the reason that is there, maybe but please be clear on the motivation
and reasoning here.

Rest is n/a until the above is clarified.


** Changed in: python-invoke (Ubuntu)
       Status: New => Incomplete

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2138736

Title:
  [MIR] python-invoke (paramiko dependency)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/python-invoke/+bug/2138736/+subscriptions


-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to