Hi Kai-Chuan, Thank you for removing those HDMI commits. I have a few more notes about your debdiff before I will sponsor a new upload though:
- Please place the new patch files in a new directory inside the d/p/ folder, like what Bin Li did for 1.2.12-1ubuntu2.2 on questing. Your one is all flat, and its hard to tell what LP bug these files belong to at a glance: - d/p/0001-ucm2-sof-soundwire-add-rt712-VA-device.patch - d/p/0001-ucm2-sof-soundwire-add-rt712-vb-device.patch - d/p/0001-ucm2-sof-soundwire-add-rt721-ucm-support.patch - d/p/0001-ucm2-sof-soundwire-support-rt713vb-codec.patch - d/p/0001-ucm2-rt712-simplify-the-init-settings.patch - d/p/0001-sof-soundwire-fix-for-sdca-variants-for-multi-codec.patch - d/p/0001-sof-soundwire-second-fix-for-sdca-variants-for-multi.patch - d/p/0001-rt713-add-mic-led-support.patch - d/p/0001-sof-soundwire-third-fix-for-multi-codec.patch - d/p/0001-ucm2-codecs-rt722-add-condition-to-SetLED-for-mic.patch while on Bin Li's 1.2.12-1ubuntu2.2 questing upload, they are like: - d/p/lp2129952/0001-ucm2-sof-soundwire-add-rt712-VA-device.patch - d/p/lp2129952/0001-ucm2-sof-soundwire-add-rt712-vb-device.patch - d/p/lp2129952/0001-ucm2-sof-soundwire-add-rt721-ucm-support.patch - d/p/lp2129952/0001-ucm2-sof-soundwire-support-rt713vb-codec.patch - d/p/lp2129952/0001-ucm2-rt712-simplify-the-init-settings.patch - d/p/lp2129952/0001-sof-soundwire-fix-for-sdca-variants-for-multi-codec.patch - d/p/lp2129952/0001-sof-soundwire-second-fix-for-sdca-variants-for-multi.patch - d/p/lp2129952/0001-rt713-add-mic-led-support.patch - d/p/lp2129952/0001-sof-soundwire-third-fix-for-multi-codec.patch - d/p/lp2129952/0001-ucm2-codecs-rt722-add-condition-to-SetLED-for-mic.patch Its tidier and easier to read. Usually, I would also ask that you number your patches, e.g.: d/p/lp2129952/0001-ucm2-sof-soundwire-add-rt712-VA-device.patch d/p/lp2129952/0002-ucm2-sof-soundwire-add-rt712-vb-device.patch d/p/lp2129952/0003-ucm2-sof-soundwire-add-rt721-ucm-support.patch ... and so on, it makes it easier to see what order things are in when you run "ls" or "ls -l". Make sure you get the order correct! I suggest you keep using the order from d/p/series: diff -Nru alsa-ucm-conf-1.2.10/debian/patches/series alsa-ucm-conf-1.2.10/debian/patches/series --- alsa-ucm-conf-1.2.10/debian/patches/series 2025-12-05 11:13:13.000000000 +0800 +++ alsa-ucm-conf-1.2.10/debian/patches/series 2025-12-18 12:30:09.000000000 +0800 @@ -47,3 +47,13 @@ 0007-ucm2-MediaTek-mt8390-evk-Add-support-for-SOF.patch 0008-ucm2-MediaTek-mt8365-evk-Add-SOF-support.patch 0009-ucm2-MediaTek-mt8395-evk-Add-support-for-SOF.patch +0001-ucm2-sof-soundwire-add-rt712-VA-device.patch +0001-ucm2-sof-soundwire-add-rt712-vb-device.patch +0001-ucm2-sof-soundwire-add-rt721-ucm-support.patch +0001-ucm2-sof-soundwire-support-rt713vb-codec.patch +0001-ucm2-rt712-simplify-the-init-settings.patch +0001-sof-soundwire-fix-for-sdca-variants-for-multi-codec.patch +0001-sof-soundwire-second-fix-for-sdca-variants-for-multi.patch +0001-rt713-add-mic-led-support.patch +0001-sof-soundwire-third-fix-for-multi-codec.patch +0001-ucm2-codecs-rt722-add-condition-to-SetLED-for-mic.patch For your dep3 tags in the patches, you used the Origin: upstream keyword. This is good, it's just that you mentioned you needed to change some patches to apply cleanly, and they would be a "backport" instead of "upstream". "upstream" is for clean cherry-picks only. If you need to modify a patch to make it work, please use the "backport" word instead of "upstream". e.g. Origin: backport, https://github.com/alsa-project/alsa-ucm- conf/commit/50ff69ec255ccc94c5bc24c8d63cc5cff7278aaa I would also ask that you include the Bug-Ubuntu dep3 tag in your patches as well, as it makes it easier to see what LP bug a given patch relates to. e.g. Bug-Ubuntu: https://bugs.launchpad.net/bugs/2129952 You can place it directly below the "Origin" tag. If you can make these changes, please upload a new debdiff, and I will sponsor this tomorrow. Thanks, Matthew -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2129952 Title: Support for Realtek audio solution ALC3329B+ALC1708B on new Dell PTL platform To manage notifications about this bug go to: https://bugs.launchpad.net/hwe-next/+bug/2129952/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
