Review for Source Package: gst-thumbnailers
[Summary]
The essence of the review result from the MIR POV is that this is a
well-packaged rust program that produces audio/video thumbnails for the GNOME
desktop. The package demonstrates good packaging hygiene, an active upstream,
proper Rust-debian packaging procedures and has comprehensive testing. Once a
security review is complete and an owner is subscribed, it can be promoted to
Main.
MIR team ACK.
This does need a security review, so I'll assign ubuntu-security
List of specific binary packages to be promoted to main: gst-audio-thumbnailer,
gst-video-thumbnailer.
Notes:
Recommended TODOs:
- The package should get a team bug subscriber before being promoted
[Rationale, Duplication and Ownership]
There is no other package in main providing the same functionality - This
package supercedes Totem thumbnailers and is the official recommended solution
for thumbnailing
A team is committed to own long term maintenance of this package -
~desktop-packages but they are not subscribed as of this writing
The rationale given in the report seems valid and useful for Ubuntu.
[Dependencies]
OK:
- no other runtime Dependencies to MIR due to this - everything is in Main
already or vendored.
- no other build-time Dependencies with active code in the final binaries
to MIR due to this
- no -dev/-debug/-doc packages that need exclusion
- No dependencies in main that are only superficially tested requiring
more tests now.
Problems: None
[Embedded sources and static linking]
OK:
- the package vendors rust crates under missing-sources/ and are recorded in
XS-Vendored-Sources-Rust in d/control.
- no static linking
- does not have unexpected Built-Using entries
- not a go package, no extra constraints to consider in that regard
- vendoring is used, but the reasoning is sufficiently explained
- Rust package that has all dependencies vendored. It does neither
have *Built-Using (after build). Nor does the build log indicate
built-in sources that are missed to be reported as Built-Using.
- rust package that uses dh-cargo and builds via –buildsystem=meson+ninja
- Includes vendored code, the package has documented how to refresh this
code at debian/README.source
Problems: None
[Security]
OK:
- history of CVEs does not look concerning
- does not run a daemon as root
- does not use webkit1,2
- does not use lib*v8 directly
- does parse data formats (files [images, video, audio,
xml, json, asn.1], network packets, structures, ...) from
an untrusted source.
=> This package does parse audio and video files from potentially untrusted
sources however the parsing library used, GStreamer, is a trusted package in
Ubuntu Main and widely deployed. This package is still worthy of a security
review.
- does not expose any external endpoint (port/socket/... or similar)
- does not process arbitrary web content
- does not use centralized online accounts
- does not integrate arbitrary javascript into the desktop
- does not deal with system authentication (eg, pam), etc)
- does not deal with security attestation (secure boot, tpm, signatures)
- does not deal with cryptography (en-/decryption, certificates,
signing, ...)
- this makes appropriate (for its exposure) use of established risk
mitigation features (dropping permissions, using temporary environments,
restricted users/groups, seccomp, systemd isolation features,
apparmor, ...)
Problems: The parsing of untrusted data formats makes this a candidate
for a security review.
[Common blockers]
OK:
- does not FTBFS currently
- does have a test suite that runs at build time - cargo test
- test suite fails will fail the build upon error.
- does have a non-trivial test suite that runs as autopkgtest
- This does not need special HW for build or test
- no new python2 dependency
Problems: None
[Packaging red flags]
OK:
- Ubuntu does carry a delta, but it is reasonable and maintenance under
Control - 4 patches but fairly minor in scope
- symbols tracking not applicable for this kind of code.
- debian/watch is present and looks ok (if needed, e.g. non-native)
- Upstream update history is good - releases roughly monthly
- Debian/Ubuntu update history is good - brand new universe package
- the current release is packaged
- promoting this does not seem to cause issues for MOTUs that so far
maintained the package
- no massive Lintian warnings
- debian/rules is rather clean
- It is not on the lto-disabled list
Problems: None
[Upstream red flags]
RULE: flag common issues:
RULE: - if you see anything else odd, speak up and ask for clarification
OK:
- no Errors/warnings during the build
- no incautious use of malloc/sprintf (the language has no direct MM)
- no use of sudo, gksu, pkexec, or LD_LIBRARY_PATH (usage is OK inside
tests)
- no use of user 'nobody' outside of tests
- no use of setuid / setgid
- no important open bugs (crashers, etc) in Debian or Ubuntu
- no dependency on webkit, qtwebkit or libseed
- not part of the UI for extra checks
- no translation present, but none needed for this case (user visible)?
Problems: None
** Changed in: ubuntu
Assignee: Myles Penner (mylesjp) => (unassigned)
** Changed in: ubuntu
Assignee: (unassigned) => Ubuntu Security Team (ubuntu-security)
** Changed in: ubuntu
Status: Confirmed => New
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2137712
Title:
[MIR] gst-thumbnailers
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+bug/2137712/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
