Hey Simon, I've reviewed crypto-policies in NEW, here are my review comments
* debian/control - nitpick but if you bump Standards-Version to 4.7.3 you can remove "Priority: optional" - please use `wrap-and-sort` to sort out dependencies by alphabetical order and have standard indentation * debian/copyright - the RH copyright start year is wrong update-crypto-policies.8.txt:Copyright (C) 2014-2021 Red Hat, Inc. - you are missing those copyright owners Copyright (c) 2022 Alexander Sosedkin <[email protected]> Copyright (c) 2019 Tomáš Mráz <[email protected]> - using decopy generates that section Files: COPYING.LESSER crypto-policies.7.txt fips-crypto-policy-overlay fips-setup-helper python/* tests/unit/* update-crypto-policies.8.txt Copyright: 2022, Alexander Sosedkin <[email protected]> 1991-1999, Free Software Foundation, Inc 2014-2022, Red Hat, Inc 2019, Tomáš Mráz <[email protected]> License: LGPL-2.1+ which is right, the copyright needs to be updated to reflect that those files are under LGPL-2.1+ and not LGPLG-2.1 * debian/patches/0003-Remove-Fedora-specific-policies-and-tests.patch Any reason why we need to remove pol files from the source? it makes the patch long and will mean it will need to be rebased every time one of those files changes. Wouldn't it be easier to just not install those in the deb binary package (and adapt tests to not run the corresponding parts if needed)? I'm rejecting the current upload because I would like the see the d/copyright updated before the package is accepted. The other points are more questions/small improvements that would be nice to have but not blockers for NEW approval -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2138940 Title: [needs-packaging] crypto-policies To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/crypto-policies/+bug/2138940/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
