Hi Antoine,
FWIW here is my review of the packaging.
Copyright:
- vendor/github.com/cyphar/filepath-securejoin is a mixture of BSD-3-clause and
MPL-2.0 - BSD-3-clause files are missing, default is MPL-2.0
- pmezard - Should be BSD-3
- urfave - can be more compact - all MIT/Expat
- sirupsen - Copyright 2012, Miki Tebeka <[email protected]> missing
Lintian - I have these lintian errors/warnings when building your linked
repository locally and running lintian -EvIL -pedantic on the changes files.
Interestingly enough those are not present in your linked ppa build:
- E: nvidia-container-toolkit source: missing-notice-file-for-apache-license
[tests/vendor/go.yaml.in/yaml/v3/NOTICE]
- E: nvidia-container-toolkit source: missing-notice-file-for-apache-license
[vendor/github.com/opencontainers/runc/NOTICE]
- E: nvidia-container-toolkit source: missing-notice-file-for-apache-license
[vendor/gopkg.in/yaml.v3/NOTICE]
- E: nvidia-container-toolkit source: missing-notice-file-for-apache-license
[vendor/sigs.k8s.io/yaml/goyaml.v2/NOTICE]
- W: nvidia-container-toolkit-base: mismatched-override
spelling-error-in-binary modfied modified [usr/nvidia-cdi-hook]
[usr/share/lintian/overrides/nvidia-container-toolkit-base:8]
- unused-override hardening-no-bindnow for all your packages
Rules:
- There is an override for dh_dwz, but no reason why. If this is normal/usual
for golang, sorry for the noise.
General:
- nvidia-container-toolkit.{pre,post}inst - is there a need to create the
symlink this way? Wouldn't an override in the rules be cleaner, like:
```
override_dh_link:
dh_link
dh_link -p nvidia-container-toolkit
usr/bin/nvidia-container-runtime-hook usr/bin/nvidia-container-toolkit
```
- There is a changelog.old file in the debian folder. I assume this is a
leftover and should be removed?
- Is the debian/prepare intended to stay?
- The d/tests/build is more of a smoke test I'd say, as it only executes --help.
- Both patches are missing the `>` character in your mail address
- The order in d/patches/series is not what you'd expect from the numbering :)
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2138390
Title:
[needs-packaging] nvidia-container-toolkit
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+bug/2138390/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
