ahasenack, I've improved the test plan now.

I've also realized that questing is unaffeceted, as the gnome portal
does not use this memory-leaking Gtk widget anymore. There technically
still exists a bug in GTK4 in questing but reproducing would require an
application specifically using this (deprecated) widget. For now let's
skip questing, please reject that upload.

** Description changed:

  [ Impact ]
  
- The gnome portal can leak a lot of memory (reaching GB's easily), due to
- not using a long touch gesture in file chooser.
+ The gnome portal can leak a lot of memory due to it creating but never
+ attaching (and thus never free'ing) the long-touch gesture in file
+ chooser.
  
  Some info here, problem exists on 24.04
  https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/9109
  https://gitlab.gnome.org/GNOME/xdg-desktop-portal-gnome/-/issues/118
  
  [ Test case ]
  
- In a snap or flatpak application (that must use file portal), open a file:
-   1. The file chooser should support the long touch gesture when using a 
touch device
+ 0. Setup Ubuntu 24.04 on a touch device
  
- In general the process should not leak memory, this can be tested using
- massif or just inspecting `ps` for the memory used by the process
+ 1. Open the Firefox snap
+ 2. Press Alt
+ 3. Navigate to File > Open File
+ 4. Verify that the file chooser appears
+ 5. With a touch device, touch and hold on a file
+ 6. Verify that the context menu appears
+ 
+ 7. Within the file chooser, repeatedly navigate in-and-out of directories 
with many files
+ 8. Verify that the memory usage of the `xdg-desktop-portal-gnome` process is 
not constantly increasing
+ 
  
  [ Where problems could occur ]
  
  The patch has been used in various upstream releases already and so far
  did not spot any problem, the gesture now works properly and no leak can
  be detected.

** Changed in: gtk4 (Ubuntu Noble)
       Status: Incomplete => In Progress

** Changed in: gtk4 (Ubuntu Questing)
       Status: Incomplete => Invalid

** Changed in: gtk4 (Ubuntu Questing)
       Status: Invalid => Won't Fix

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2085698

Title:
  Gesture in file chooser are not added, leading an huge Memory leak

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gtk4/+bug/2085698/+subscriptions


-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to