Hi Tzu-Hsien, You have a very nice SRU template, nicely written, well done.
My only feedback for you is I want to see the LP bug number in your patch filenames: e.g. d/p/0010-ucm2-MediaTek-mt8391-evk-Add-alsa-ucm-support.patch becomes d/p/lp2139651-ucm2-MediaTek-mt8391-evk-Add-alsa-ucm-support.patch so its really easy to see what patch belongs to what bug at a glance. Otherwise d/p/* inside alsa-ucm-conf is a mess: $ ll total 276 drwxrwxr-x 3 matthew matthew 4096 Jan 27 19:46 ./ drwxrwxr-x 5 matthew matthew 4096 Jan 27 19:46 ../ -rw-rw-r-- 1 matthew matthew 1992 Dec 5 15:49 0001-Turn-speaker-LED-accroding-to-rt1318-speaker-status.patch -rw-rw-r-- 1 matthew matthew 1447 Dec 5 15:52 0001-acppdmmach-add-support-for-ACP-7.0.patch -rw-rw-r-- 1 matthew matthew 1295 Dec 5 15:52 0001-amd-soundwire-add-support-for-AMD-generic-legacy-mac.patch -rw-rw-r-- 1 matthew matthew 974 Dec 5 15:41 0001-rt722-change-output-volume-of-headphone-to-0dB.patch -rw-rw-r-- 1 matthew matthew 3896 Dec 5 15:41 0001-sof-soundwire-Add-LED-support-for-cs35l56-amplifiers.patch -rw-rw-r-- 1 matthew matthew 1488 Dec 5 15:52 0001-sof-soundwire-Add-basic-support-for-cs42l43-s-speake.patch -rw-rw-r-- 1 matthew matthew 1051 Dec 5 15:52 0001-sof-soundwire-Add-missing-match-for-cs42l43-speakers.patch -rw-rw-r-- 1 matthew matthew 3155 Dec 5 15:52 0001-sof-soundwire-Change-map-control-names-to-make-them-.patch -rw-rw-r-- 1 matthew matthew 10359 Dec 5 15:52 0001-sof-soundwire-Use-one-file-for-speaker-codec-initial.patch -rw-rw-r-- 1 matthew matthew 1648 Dec 5 15:52 0001-sof-soundwire-cs42l43-spk-Correct-PlaybackPCM-and-ro.patch -rw-rw-r-- 1 matthew matthew 751 Dec 5 15:52 0001-sof-soundwire-fix-rt1318-config-typo-in-rt1318spk-ma.patch -rw-rw-r-- 1 matthew matthew 2251 Dec 5 15:52 0001-ucm-MediaTek-mt8395-evk-Add-HDMIRX-config.patch -rw-rw-r-- 1 matthew matthew 2409 Dec 5 16:13 0001-ucm2-MediaTek-mt8370-evk-Add-dynamic-configuration-f.patch -rw-rw-r-- 1 matthew matthew 5681 Dec 5 15:52 0001-ucm2-MediaTek-mt8390-evk-Add-alsa-ucm-support.patch -rw-rw-r-- 1 matthew matthew 9120 Dec 5 15:34 0001-ucm2-add-PinePhone-configuration.patch -rw-rw-r-- 1 matthew matthew 2773 Dec 5 15:52 0001-ucm2-conf.d-mt8370-evk-Fix-the-type-of-mt8370-evk.co.patch -rw-rw-r-- 1 matthew matthew 4543 Dec 5 15:52 0001-ucm2-soundwire-add-rt713-SDCA-device.patch -rw-rw-r-- 1 matthew matthew 4596 Dec 5 15:52 0001-ucm2-soundwire-add-rt722-SDCA-device.patch -rw-rw-r-- 1 matthew matthew 1862 Dec 5 15:52 0002-sof-soundwire-Add-basic-support-for-basic-cs35l56-co.patch -rw-rw-r-- 1 matthew matthew 1897 Dec 5 15:52 0002-sof-soundwire-Add-sequence-for-controlling-Mic-Mute-.patch -rw-rw-r-- 1 matthew matthew 3046 Dec 5 15:52 0002-sof-soundwire-Add-support-for-cs42l43-cs35l56-bridge.patch -rw-rw-r-- 1 matthew matthew 1965 Dec 5 15:52 0002-sof-soundwire-cs42l43-Correct-CapturePCM-and-routing.patch -rw-rw-r-- 1 matthew matthew 1270 Dec 5 15:52 0002-sof-soundwire-fix-missing-MultiCodec1-initialization.patch -rw-rw-r-- 1 matthew matthew 1029 Dec 5 15:52 0002-sof-soundwire-fix-rt1318-config-copy-n-paste-error-i.patch -rw-rw-r-- 1 matthew matthew 1948 Dec 5 15:41 0002-sof-soundwire-rt1318-add-playback-control-switch.patch -rw-rw-r-- 1 matthew matthew 2409 Dec 5 16:13 0002-ucm2-MediaTek-mt8390-evk-Add-dynamic-configuration-f.patch -rw-rw-r-- 1 matthew matthew 5561 Dec 5 15:52 0002-ucm2-MediaTek-mt8395-evk-Add-alsa-ucm-support.patch -rw-rw-r-- 1 matthew matthew 3942 Dec 5 15:34 0002-ucm2-add-PineTab-configuration.patch -rw-rw-r-- 1 matthew matthew 3636 Dec 5 15:52 0003-sof-soundwire-Add-basic-support-for-cs42l43.patch -rw-rw-r-- 1 matthew matthew 1460 Dec 5 15:52 0003-sof-soundwire-rt1308-Fix-single-amp-configuration.patch -rw-rw-r-- 1 matthew matthew 5654 Dec 5 15:52 0003-ucm2-MediaTek-mt8370-evk-Add-alsa-ucm-support.patch -rw-rw-r-- 1 matthew matthew 2407 Dec 5 16:13 0003-ucm2-MediaTek-mt8395-evk-Add-dynamic-configuration-f.patch -rw-rw-r-- 1 matthew matthew 5710 Dec 5 15:34 0003-ucm2-add-improved-Librem-5-profiles.patch -rw-rw-r-- 1 matthew matthew 1698 Dec 5 15:52 0003-ucm2-sof-soundwire-Correct-FixedBootSequence-for-dmi.patch -rw-rw-r-- 1 matthew matthew 1924 Dec 5 15:52 0003-ucm2-sof-soundwire-add-RT1320-amplifier.patch -rw-rw-r-- 1 matthew matthew 912 Dec 5 15:52 0004-rt722-add-mic-led-support.patch -rw-rw-r-- 1 matthew matthew 3275 Dec 5 15:52 0004-sof-soundwire-Split-cs42l43-dmic-initialisation.patch -rw-rw-r-- 1 matthew matthew 1619 Dec 5 15:52 0004-sof-soundwire-rt1316-rt1318-fix-channel-selection-fo.patch -rw-rw-r-- 1 matthew matthew 1088 Dec 5 16:13 0004-ucm2-MediaTek-mt8370-evk-Add-headset-jack-detection.patch -rw-rw-r-- 1 matthew matthew 1786 Dec 5 15:52 0005-sof-soundwire-Fix-cs42l43-dmic-initialisation.patch -rw-rw-r-- 1 matthew matthew 1088 Dec 5 16:13 0005-ucm2-MediaTek-mt8390-evk-Add-headset-jack-detection.patch -rw-rw-r-- 1 matthew matthew 3012 Dec 5 15:52 0006-common-add-led.conf-with-SetLED-macro-to-hide-implem.patch -rw-rw-r-- 1 matthew matthew 1090 Dec 5 16:13 0006-ucm2-MediaTek-mt8395-evk-Add-headset-jack-detection.patch -rw-rw-r-- 1 matthew matthew 7023 Dec 5 16:13 0007-ucm2-MediaTek-mt8390-evk-Add-support-for-SOF.patch -rw-rw-r-- 1 matthew matthew 7609 Dec 5 15:52 0007-ucm2-use-new-SetLED-macro-to-hide-the-implementation.patch -rw-rw-r-- 1 matthew matthew 1284 Dec 5 15:52 0008-sof-soundwire-cs42l43-Drop-headset-mic-from-mic-mute.patch -rw-rw-r-- 1 matthew matthew 10114 Dec 5 16:13 0008-ucm2-MediaTek-mt8365-evk-Add-SOF-support.patch -rw-rw-r-- 1 matthew matthew 4777 Dec 5 15:52 0009-sof-soundwire-Add-LED-support-for-cs35l56-amplifiers.patch -rw-rw-r-- 1 matthew matthew 3526 Dec 5 16:13 0009-ucm2-MediaTek-mt8395-evk-Add-support-for-SOF.patch -rw-rw-r-- 1 matthew matthew 2482 Dec 5 15:55 0010-sof-soundwire-cs42l43-Switch-mixer-based-on-output-v.patch drwxrwxr-x 2 matthew matthew 4096 Jan 27 19:46 lp2129952/ -rw-rw-r-- 1 matthew matthew 3518 Jan 27 19:46 series What patch belongs to what bug? Its hard to tell. Now, in the patch file itself, I want to see proper dep3 tagging. https://dep-team.pages.debian.net/deps/dep3/ At the very least, please add "Origin" and "Bug-Ubuntu". e.g.: From 0d40e081dce2371fd4d37c8f184fd5be4b144601 Mon Sep 17 00:00:00 2001 From: Zoran Zhan <[email protected]> Date: Thu, 28 Aug 2025 11:10:44 +0800 Subject: [PATCH] ucm2: MediaTek: mt8391-evk: Add alsa-ucm support Add alsa-ucm support for the MediaTek mt8391-evk platform. Closes: https://github.com/alsa-project/alsa-ucm-conf/pull/607 Signed-off-by: Zoran Zhan <[email protected]> Signed-off-by: Jaroslav Kysela <[email protected]> Origin: upstream, https://github.com/alsa-project/alsa-ucm-conf/commit/0d40e081dce2371fd4d37c8f184fd5be4b144601 Bug: https://github.com/alsa-project/alsa-ucm-conf/pull/607 Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/alsa-ucm-conf/+bug/2139651 Last-Updated: 2026-02-11 Now when I look at a patch, I can easily see what Launchpad bug it belongs to. You can make these changes and re-upload a debdiff if you like. I am going to merge your patches with https://bugs.launchpad.net/ubuntu/resolute/+source/alsa-ucm-conf/+bug/2131725 and upload them at the same time, so you have until Kai-Chuan has answered my question in his bug. Thanks, Matthew -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2139651 Title: [SRU] Add ALSA UCM support for MediaTek MT8391-EVK platform To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/alsa-ucm-conf/+bug/2139651/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
