Hi, and thanks for the patches. For systemd packaging we use the following git repo: https://code.launchpad.net/~ubuntu-core- dev/ubuntu/+source/systemd/+git/systemd
Please open PRs there, rather than posting debdiffs. But, since I am here, here is a first review on the debdiffs: > diff -Nru systemd-257.9/debian/changelog systemd-257.9/debian/changelog > --- systemd-257.9/debian/changelog 2025-12-08 14:30:21.000000000 +0000 > +++ systemd-257.9/debian/changelog 2026-02-12 12:44:14.000000000 +0000 > @@ -1,3 +1,9 @@ > +systemd (257.9-0ubuntu2.2) questing; urgency=medium > + > + * systemd: restarting systemd timer triggers service start off-schedule > (LP #2141296) Please describe the fix, rather than the problem. Reading this entry, it is not clear to me what this upload is changing. I usually prefer to use the first line of the upstream commit, which is more clear in this case too. Also: the bug number format needs to contain ":", i.e. (LP: #2141296). Otherwise, the tooling does not pick it up. > + > + -- Ioana Lazea <[email protected]> Thu, 12 Feb 2026 12:44:14 +0000 > + > systemd (257.9-0ubuntu2.1) questing; urgency=medium > > * net_id: depending on new udev prop, include/exclude PCI domain from > netif names > diff -Nru systemd-257.9/debian/patches/lp2141296-dont-restart-timer.patch > systemd-257.9/debian/patches/lp2141296-dont-restart-timer.patch > --- systemd-257.9/debian/patches/lp2141296-dont-restart-timer.patch > 1970-01-01 00:00:00.000000000 +0000 > +++ systemd-257.9/debian/patches/lp2141296-dont-restart-timer.patch > 2026-02-12 12:43:24.000000000 +0000 > @@ -0,0 +1,24 @@ > +Description: Restarting systemd timer triggers service start off-schedule > +When a timer is restarted, don't reset the last_trigger field. This prevents > +the timer from triggering immediately. Before the fix, after restarting the > +timer, the service would run again regardless of schedule. Please use the upstream commit message rather than adding your own. In fact, it would be better to start with a `git format-patch` patch, and simply add the Bug, Bug-Ubuntu, and Origin fields after. > +Author: Lukas Nykryn This field is unnecessary since we are pointing to the upstream commit. > +Origin: upstream, https://github.com/systemd/systemd/pull/38868 Please use a link to the actual commit, not the PR. I.e. https://github.com/systemd/systemd/commit/3fc44a0f68412b649e16f12ff2f97a36c615457d. > +Bug: https://github.com/systemd/systemd/issues/31231 > +Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/2141296 > +Applied-Upstream: commit, > https://github.com/keszybz/systemd/commit/c08f4d087052169e65f76303a480e7839e8cf763 This is unnecessary, since we have the Origin field. Also, this is pointing to Zbyszek's fork, not upstream. > +--- > +This patch header follows DEP-3: http://dep.debian.net/deps/dep3/ > +Index: systemd-257.9/src/core/timer.c > +=================================================================== > +--- systemd-257.9.orig/src/core/timer.c > ++++ systemd-257.9/src/core/timer.c > +@@ -654,8 +654,6 @@ static int timer_start(Unit *u) { > + if (r < 0) > + return r; > + > +- t->last_trigger = DUAL_TIMESTAMP_NULL; > +- > + /* Reenable all timers that depend on unit activation time */ > + LIST_FOREACH(value, v, t->values) > + if (v->base == TIMER_ACTIVE) > diff -Nru systemd-257.9/debian/patches/series > systemd-257.9/debian/patches/series > --- systemd-257.9/debian/patches/series 2025-12-08 14:28:28.000000000 > +0000 > +++ systemd-257.9/debian/patches/series 2026-02-12 12:37:04.000000000 > +0000 > @@ -14,3 +14,4 @@ > test-skip-TEST-50-DISSECT.dissect.patch > lp2125405-basic-validate-timezones-in-get_timezones.patch > lp2134334-net_id_depending_on_new_udev_prop_include_exclude_pci_dom.patch > +lp2141296-dont-restart-timer.patch > ** Bug watch added: github.com/systemd/systemd/issues #31231 https://github.com/systemd/systemd/issues/31231 ** Changed in: systemd (Ubuntu Questing) Status: In Progress => Incomplete ** Changed in: systemd (Ubuntu Noble) Status: In Progress => Incomplete -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2141296 Title: [00427578] Restarting systemd timer triggers service start off- schedule To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/2141296/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
