Sorry for the silence, Christian! I had drafted a reply but apparently never sent it. It was a busy week :/
Thanks a lot of the review! I'll reply to some things below. > - Lintian check > Happy except a few copyright warnings which we will get into in the next spot I was surprised about that, because we run Lintian in our CI. Turns out the shared build-debian GitHub action ignored the Lintian exit code *facepalm*. That's fixed with https://github.com/canonical/desktop- engineering/pull/100 > - License/Copyright checks > [...] I confirm those issues, and there are actually a lot more issues reported on main (the version we uploaded is based on the last stable release, which was a while ago). I'm working on solving the copyright issues (and other Lintian issues) on main first and then I plan to do the same for the version we uploaded. I'll make sure that both Lintian and licenserecon are happy. Because of all the vendored dependencies we have (far too many for my liking), a complete debian/copyright file requires hundreds of entries. It seems unmaintainable to me to do that manually, so I've now been using decopy (https://salsa.debian.org/debian/decopy) to generate the file. It still requires a lot of manual work to clean things up afterwards, but I didn't find anything better. Please let me know if you know of a better way. > There are a few more like > P: authd: spelling-error-in-copyright Unknwon Unknown Funny enough, that's not a typo. The author of those Go packages actually uses the name "Unknwon: https://ini.unknwon.io/ I will suppress that warning (and a few others) by adding it to debian/source/lintian-overrides. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2136731 Title: [needs-packaging] authd To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/authd/+bug/2136731/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
