Hi Will, I just had a look at the new package
and I found:
"W: onedpl source: syntax-error-in-dep5-copyright Continuation line not in
paragraph (line 92). Missing a dot on the previous line? [debian/copyright]"
May I ask to fix this?
But the msg is btw. a bit misleading, since it's not a "dot" that is needed in
line 92, but the next license, starting in line 93, must not start with a space
(as first character).
And when having this solved, it brings two more warnings (which is really more
one issue):
"W: onedpl source: missing-license-paragraph-in-dep5-copyright apache-2.0
and/or bsd-3-clause [debian/copyright:31]
W: onedpl source: space-in-std-shortname-in-dep5-copyright apache-2.0 and/or
bsd-3-clause [debian/copyright:31]"
This is first of all because there is no concept of a combined "and/or"
in d/copyright, just either "and" or "or".
BUT from all what I can see is that:
a) "include/oneapi/dpl/internal/reduce_by_segment_impl.h" and
b)
"include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl_reduce_by_segment.h"
are just "Apache-2.0"
and
c) "include/oneapi/dpl/internal/reduce_by_segment_impl.h"
is "Apache-2.0 WITH LLVM-exception"
And all three of them are copyright Intel and Nvidia.
Ok, to sum things up:
You can split up block:
"
Files: include/oneapi/dpl/internal/reduce_by_segment_impl.h
include/oneapi/dpl/internal/scan_by_segment_impl.h
include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl_reduce_by_segment.h
Copyright: 2008-2013 NVIDIA Corporation
2025-2025 Intel Corporation
License: Apache-2.0 and/or BSD-3-clause
"
into
"
Files: include/oneapi/dpl/internal/reduce_by_segment_impl.h
include/oneapi/dpl/pstl/hetero/dpcpp/parallel_backend_sycl_reduce_by_segment.h
Copyright: 2008-2013 NVIDIA Corporation
2023-2025 Intel Corporation
License: Apache-2.0
Files: include/oneapi/dpl/internal/scan_by_segment_impl.h
Copyright: 2013 NVIDIA Corporation
2023 Intel Corporation
License: Apache-2.0-with-LLVM-exception
"
And since the "BSD-3-clause" part is no longer needed (and I couldn't find any
relevant BSD lisenced code in the src folder), you can remove the entire
BSD-3-clause license text.
But you need to add a license text for "Apache-2.0-with-LLVM-exception" instead.
And when doing the change, you could also remove one of the two blank
lines 32/33 (doesn't hurt much, but one is sufficient).
Long story (that I only added for explanation) short (since I did the work
already),
I attached the copyright file that should be the correct one here.
You would also need to add a bullet about these changes in your changelog, like:
* Modify d/copyright to fix lintian messages and make it conform to latest
source code level.
(or so)
** Attachment added: "copyright"
https://bugs.launchpad.net/ubuntu/+bug/2130191/+attachment/5945812/+files/copyright
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2130191
Title:
[needs-packaging] onedpl
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+bug/2130191/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
