Having a look at this (again) as part of a patch pilot shift. The
packaging is somewhat unorthodox in places, but there seem to be good
reasons for much of this. Still, some things do need changes:
d/watch: This exists (good) but relies upon a d/get-orig-source script
to re-pack the upstream source because otherwise the build process
attempts to download pre-built (signed) artifacts which wouldn't be
allowed on our builders. While I can't say I much like this, I don't see
a cleaner way around this. However, where the upstream sources have been
repacked, the upstream version should be modified to clearly indicate
that our orig tar-ball won't match the upstream.
For example, the d/get-orig-source script could append something like
"+prebuilt" to the upstream version, giving linux-
sgx_2.26.100.0+prebuilt.orig.tar.gz (giving the eventual version
2.26.100.0+prebuilt-0ubuntu1 for d/changelog).
I note that sgx-setup exists solely to create a new group (sgx_prv) and
install a udev rules file to assign that group to whatever devices
sgx_provision creates. The postinst creating the group is good (and I
note there's no postrm removing the group, which is the correct choice),
but we tend to try and avoid using groups for device access these days
-- would it be possible to use the uaccess mechanism here instead? Or is
there a good reason to use a group instead?
d/{post,pre}{inst,rm}: The postinst/preinst/prerm scripts under debian/
don't appear to be associated with any of the binary packages
constructed. These scripts also appear to point to things under
/opt/intel which isn't present in any of the packages (correctly). If
these aren't required, they should be removed.
d/control: None of the binary packages produced have a description, just
a single-line summary. A clear description of each binary package's
content and purpose should be included.
d/control: The standards version is out of date (should be 4.7.2 for
resolute)
d/control: This is marked as only building for architecture amd64, which
is probably reasonable given this is Intel-specific, but presumably this
should now include amd64v3 as well?
d/copyright: Empty; this needs filling out
d/changelog: Should include a reference to this bug, e.g. "Initial
upload to Ubuntu (LP: #2129761)"
d/changelog: The package currently targets questing but should now be
bumped to resolute. Honestly I'd be surprised if this can be reviewed
before feature-freeze, but an exception could be applied for if this is
important.
There's probably more I've missed but a test build locally is taking a
very long time (it doesn't seem to be running in parallel which is odd).
If it finishes before my shift ends I'll add more from lintian below,
but there's enough to be getting on with above.
I would strongly recommend doing a test build locally and looking at the
lintian output -- if you can get the package building cleanly for
lintian, that's usually a good start. Unsubscribing sponsors for now;
please re-subscribe when the packaging is updated.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2129761
Title:
[needs-packaging] Add package linux-sgx for Intel SGX support
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+bug/2129761/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
