Review for Source Package: src:python-lark
[Summary]
Package src:python-lark is a Python-based parsing library for context-free
grammars.
It is needed in main because src:ironic introduced it as a new runtime
dependency
to parse trait-based networking filtering expressions.
MIR team ACK.
This does not need a security review.
=> Lark is a pure-Python parsing library with no CVE history.
List of specific binary packages to be promoted to main: bin:python3-lark.
Specific binary packages built, but NOT to be promoted to main:
bin:python3-lark-doc.
Notes:
#0 - Package src:ironic, to which bin:python3-lark is a new runtime dep, is
in universe; we should probably expect an MIR for ironic too.
Required TODOs:
None.
Recommended TODOs:
#1 - Please subscribe the ubuntu-openstack team
#2 - Address the lintian warning noted in [Packaging Red Flags]
#3 - Address the doc generation errors/warnings noted in [Upstream Red Flags]
[Rationale, Duplication and Ownership]
- There is no other package in main providing the same functionality.
- A team is committed to own long term maintenance of this package.
=> The ubuntu-openstack team
- The rationale given in the report seems valid and useful for Ubuntu
=> python-lark is a new runtime dependency of src:ironic which is currently
in universe.
[Dependencies]
OK:
- no other runtime Dependencies to MIR due to this
- no other build-time Dependencies with active code in the final binaries
to MIR due to this
- no -dev/-debug/-doc packages that need exclusion
=> python-lark-doc needs to be excluded
- No dependencies in main that are only superficially tested requiring
more tests now.
Problems: None
[Embedded sources and static linking]
OK:
- no embedded source present
- no static linking
- does not have unexpected Built-Using entries
- not a go package, no extra constraints to consider in that regard
- not a rust package, no extra constraints to consider in that regard
Problems: None
[Security]
OK:
- history of CVEs does not look concerning
- does not run a daemon as root
- does not use webkit1,2
- does not use lib*v8 directly
- does not parse data formats (files [images, video, audio, xml, json, asn.1],
network packets, structures, ...) from an untrusted source.
- does not expose any external endpoint (port/socket/... or similar)
- does not process arbitrary web content
- does not use centralized online accounts
- does not integrate arbitrary javascript into the desktop
- does not deal with system authentication (eg, pam), etc)
- does not deal with security attestation (secure boot, tpm, signatures)
- does not deal with cryptography (en-/decryption, certificates, signing, ...)
- this makes appropriate (for its exposure) use of established risk
mitigation features (dropping permissions, using temporary environments,
restricted users/groups, seccomp, systemd isolation features,
apparmor, ...)
=> Not relevant; ironic uses lark to parse trait-based networking filtering
expressions.
Problems: None
[Common blockers]
OK:
- does not FTBFS currently
=> LP shows a amd64v3 failure. I got confirmation that this was a bug - an
amd64v3 build
shouldn't have been triggered in the first place.
- does have a test suite that runs at build time
- test suite fails will fail the build upon error.
- does have a non-trivial test suite that runs as autopkgtest
- This does not need special HW for build or test
- no new python2 dependency
- Python package, but using dh_python
Problems: None
[Packaging red flags]
OK:
- Ubuntu does not carry a delta
- symbols tracking not applicable for this kind of code.
- debian/watch is present and looks ok
- Upstream update history is sporadic
- Debian/Ubuntu update history is sporadic
- the current release is packaged
- promoting this does not seem to cause issues for MOTUs that so far
maintained the package
- no massive Lintian warnings
- debian/rules is rather clean
- It is not on the lto-disabled list
Problems:
- Lintian reports depends-on-obsolete-bootstrap for bin:python-lark-doc
libjs-bootstrap4 is EOL'd upstream. See [1] & [2].
[1] https://lintian.debian.org/tags/depends-on-obsolete-bootstrap.html
[2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1088592
[Upstream red flags]
OK:
- no incautious use of malloc/sprintf (the language has no direct MM)
- no use of sudo, gksu, pkexec, or LD_LIBRARY_PATH (usage is OK inside tests)
- no use of user 'nobody' outside of tests
- no use of setuid / setgid
- use of setuid, but ok because TBD (prefer systemd to set those for services)
- no important open bugs (crashers, etc) in Debian or Ubuntu
- no dependency on webkit, qtwebkit or libseed
- not part of the UI for extra checks
- no translation present, but none needed for this case
Problems:
- there are quite a few warnings in docs generation
/<<PKGBUILDDIR>>/lark/lark.py:docstring of lark.lark.Lark:29: ERROR: Unexpected
indentation. [docutils]
/<<PKGBUILDDIR>>/lark/lark.py:docstring of lark.lark.Lark:30: WARNING: Block
quote ends without a blank line; unexpected unindent. [docutils]
/<<PKGBUILDDIR>>/lark/lark.py:docstring of lark.lark.Lark:93: WARNING:
Definition list ends without a blank line; unexpected unindent. [docutils]
/<<PKGBUILDDIR>>/lark/tree.py:docstring of lark.tree.Tree:10: ERROR: Unexpected
indentation. [docutils]
/<<PKGBUILDDIR>>/lark/tree.py:docstring of lark.tree.Tree:11: WARNING: Block
quote ends without a blank line; unexpected unindent. [docutils]
/<<PKGBUILDDIR>>/docs/examples/composition/main.rst:28: WARNING: Enumerated
list ends without a blank line; unexpected unindent. [docutils]
/<<PKGBUILDDIR>>/docs/examples/composition/main.rst:30: WARNING: Inline literal
start-string without end-string. [docutils]
/<<PKGBUILDDIR>>/docs/examples/composition/main.rst:: ERROR: Anonymous
hyperlink mismatch: 1 references but 0 targets.
** Bug watch added: Debian Bug tracker #1088592
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1088592
** Changed in: python-lark (Ubuntu)
Status: New => In Progress
** Changed in: python-lark (Ubuntu)
Assignee: Pushkar Kulkarni (pushkarnk) => (unassigned)
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2140505
Title:
[MIR] python-lark
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/python-lark/+bug/2140505/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
