Thanks for fixing things here, Chloé! The diff provided in comment #5 does not seem to be correct. I would expect to see at least a d/changelog entry and the new directory (with all of its files) being added there. It seems that I am looking the the tail of a dsc file instead.
I did have a look in the diff of the FTBFS sources in the archive vs the *ubuntu2* sources in the ppa. That looks much better. Here are some comments on that diff: - The d/changelog entry says that the new plugin directory is there to create a missing tarball. I'd see it the other way around since people pulling the sources from the archive would use the tarball to create the directory. before a build from sources. - From a sponsor perspective, I am having a hard time to check the provenance of the new upstream tarball for the new plugin. I can get the hash of the commit we are pinned to from d/changelog and then get a tarball from http://github.com/GoogleCloudPlatform/google-guest- agent/archive/${HASH}.tar.gz, in this case, http://github.com/GoogleCloudPlatform/google-guest- agent/archive/e5ea53c707c2ff22ce4c56b9f1d4570551adec9d.tar.gz. Then I run $ diffoscope --new-file UPSTREAM_TARBALL PPA_TARBALL > diffoscope- output.diff And I get a large diff there which I am unsure how to assess: - The file timestamps are different, this is OK, but we could preserve them upon repacking to make the diffoscope output nicer/predictable. - I see differences on the .pb.go files, which is expected as this was automatically generated. I suppose this is exactly what we should expect from that tarball, right? In that case, I suppose the repacking of that tarball could be available in a script under debian/ do make these checks easier. So, for this upload, I'd suggest: - Fix the d/changelog entry - Either provide a correct debdiff for a sponsor or ask them to fetch the package from your PPA, adjust the version and upload For the future: - provide a script to repack that tarball and document it in d/README.source. - check if it is possible to use the uscan MUT + repacking feature to leverage this new script and automate as much as possible in d/watch (this may be harder due to the fact that we need specific commit hashes when fetching a new tarball). -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2139356 Title: Please update to 20260115.00 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/google-guest-agent/+bug/2139356/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
