Review for Source Package: src:blueprint-compiler
[Summary]
The blueprint-compiler package offers a markup language to describe
GUI interfaces in GTK applications. It compiles to GtkBuilder XML format
while building such applications/packages. Essentially, it becomes a part
of the toolchain and there is a proposal to seed it (possibly into the
desktop set).
MIR team ACK. Please consider having a look at the recommended TODOs.
This does not need a security review.
=> blueprint-compiler is a markup language compiler that translates
to GtkBuilder XML format. On Ubuntu, it is expected to be invoked during the
builds of GTK-based packages - the inputs are trusted upstream sources.
It is a pure-Python package. There is no history of CVEs.
List of specific binary packages to be promoted to main: bin:blueprint-compiler
Specific binary packages built, but NOT to be promoted to main: none
Notes:
None.
Required TODOs:
None.
Recommended TODOs:
- The package should get a team bug subscriber before being promoted
=> Please subscribe desktop-packages as planned.
- Please consider adding autopkgtests; the upstream test suite
that runs at build-time could be also run as autopkgtests.
- Please consider adding a man page, lintian reports a warning.
[Rationale, Duplication and Ownership]
- There is no other package in main providing the same functionality.
- A team is committed to own long term maintenance of this package.
=> desktop-packages
- The rationale given in the report seems valid and useful for Ubuntu
=> blueprint-compiler is a part of the toolchain that builds GTK applications,
there is a proposal to seed this package.
[Dependencies]
OK:
- no other runtime Dependencies to MIR due to this
- no other build-time Dependencies with active code in the final binaries to
MIR due to this
- no -dev/-debug/-doc packages that need exclusion
- No dependencies in main that are only superficially tested requiring more
tests now.
Problems: None
[Embedded sources and static linking]
OK:
- no embedded source present
- no static linking
- does not have unexpected Built-Using entries
- not a go package, no extra constraints to consider in that regard
- not a rust package, no extra constraints to consider in that regard
Problems: None
[Security]
OK:
- history of CVEs does not look concerning
- does not run a daemon as root
- does not use webkit1,2
- does not use lib*v8 directly
- does not parse data formats (files [images, video, audio,
xml, json, asn.1], network packets, structures, ...) from
an untrusted source.
- does not expose any external endpoint (port/socket/... or similar)
- does not process arbitrary web content
- does not use centralized online accounts
- does not integrate arbitrary javascript into the desktop
- does not deal with system authentication (eg, pam), etc)
- does not deal with security attestation (secure boot, tpm, signatures)
- does not deal with cryptography (en-/decryption, certificates, signing, ...)
- this makes appropriate (for its exposure) use of established risk
mitigation features (dropping permissions, using temporary environments,
restricted users/groups, seccomp, systemd isolation features,
apparmor, ...)
=> not relevant, blueprint-compiler is a markup language and compiler
that translates to XML.
Problems: None
[Common blockers]
OK:
- does not FTBFS currently
- does have a test suite that runs at build time
- test suite fails will fail the build upon error.
- no new python2 dependency
- Python package, but using dh_python
Problems:
- does not have a non-trivial test suite that runs as autopkgtest
[Packaging red flags]
OK:
- Ubuntu does not carry a delta
- symbols tracking not applicable for this kind of code.
- debian/watch is present and looks ok (if needed, e.g. non-native)
- Upstream update history is good
- Debian/Ubuntu update history is good
- the current release is packaged
- promoting this does not seem to cause issues for MOTUs that so far maintained
the package
- no massive Lintian warnings
- debian/rules is rather clean
- It is not on the lto-disabled list
Problems:
- W: blueprint-compiler: no-manual-page [usr/bin/blueprint-compiler]
[Upstream red flags]
OK:
- no Errors/warnings during the build
- no incautious use of malloc/sprintf (the language has no direct MM)
- no use of sudo, gksu, pkexec, or LD_LIBRARY_PATH
- no use of user 'nobody' outside of tests
- no use of setuid / setgid
- no important open bugs (crashers, etc) in Debian or Ubuntu
- no dependency on webkit, qtwebkit or libseed
- not part of the UI for extra checks
- no translation present, but none needed for this case
Problems: None
** Changed in: blueprint-compiler (Ubuntu)
Assignee: Pushkar Kulkarni (pushkarnk) => (unassigned)
** Changed in: blueprint-compiler (Ubuntu)
Status: New => In Progress
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2141402
Title:
MIR for blueprint-compiler
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/blueprint-compiler/+bug/2141402/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
