Thanks, I was checking the git content in git log v0.5.7..v0.5.8 (makes review so much easier) and compared the upload I see in the new queue.
The git changes are all fine: - I see you fixed the mandatory things in d/copyright - great, the remaining deviations are minimal and down to the expat or apache which sometimes detection is wrong - I also see various of the optional changes in regard to lintian warnings- thanks! - you also excluded unwanted dependencies - nice - fun fact, when you decided to ignore the copyright holder as many of your deps do not declare it I'm happy to see the comment in lintian-overrides. The commit message is the same. But ... changelog ... :-) It just says "debian/source/lintian-overrides: Ignore missing copyright holder because" the sentence does not continue. This isn't bad but I had to smile as we do it because ... yeah because! Reminds me of kids, but my mom teached me (translated) "because is no reason" - Also "Unknwon" is the actual name/username of the copyright holder" - lovely --- But then at release time things changed, when comparing the actual upload all the Building the actual 5.8 did trigger the dependency updates. Thereby I see: - docs going away - expected - many others like unused tests, examples and binary files going away - expected Which is just what you announced in d/changelog * Cargo.toml: Exclude unwanted files from vendored crates now coming to action. The rest was already fine on the first review, approved now. Thank you for following up on so many of my requests! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2136731 Title: [needs-packaging] authd To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/authd/+bug/2136731/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
