Public bug reported: ## FFE ##
This FFE is being requested due recommendation of ubuntu-sponsors due the amount of changes introduced in the new version of wsl-pro-service proposed to address LP: #2139225 that didn't reach the archive before feature freeze. It's needed to address the issues below: - DEP 17 compliance LP: #2139225 - Crash when the Windows home profile path contains non-ASCII chars LP: #2142666 PPA builds of this upload can be seen at: https://launchpad.net/~cnihelton/+archive/ubuntu/pplayground/+packages?field.name_filter=wsl- pro-service&field.status_filter=&field.series_filter=resolute This package is only seeded in ubuntu-wsl: $ seeded-in-ubuntu wsl-pro-service wsl-pro-service (from wsl-pro-service) is seeded in: ubuntu-wsl: daily-live It contains just a systemd unit, which only runs if 'ConditionVirtualization=wsl'. INSTALL LOGS: ---- m@DESKTOP-551PQ9O:/mnt/c/Users/João Martín😁$ sudo apt install -y wsl-pro-service Upgrading: wsl-pro-service Summary: Upgrading: 1, Installing: 0, Removing: 0, Not Upgrading: 12 Download size: 4561 kB Space needed: 311 kB / 1025 GB available Get:1 https://ppa.launchpadcontent.net/cnihelton/pplayground/ubuntu resolute/main amd64 wsl-pro-service amd64 0.1.19ubuntu [4561 kB] Fetched 4561 kB in 16s (283 kB/s) (Reading database ... 36186 files and directories currently installed.) Preparing to unpack .../wsl-pro-service_0.1.19ubuntu_amd64.deb ... Unpacking wsl-pro-service (0.1.19ubuntu) over (0.1.18build1) ... Setting up wsl-pro-service (0.1.19ubuntu) ... m@DESKTOP-551PQ9O:/mnt/c/Users/João Martín😁$ ---- TESTING: 1. Inspected the build logs to make sure lintian didn't issue warnings. Run 'lintian --pedantic' against the package downloaded from the PPA: no warnings shown. 2. Set up a WSL instance from Resolute daily images and witnessed the crash due the user profile folder being located at a path with non-ASCII characters. After installing the version from the PPA, I witnessed the service starting correctly. 3. Set up a WSL instance from Resolute daily images and witnessed it doesn't crash due the user profile folder being located at a path with only ASCII characters. After installing the version from the PPA, I witnessed the service starting correctly, confirming no regression due changes in this logic. 4. Tested also on a LXD instance to confirm the service doesn't attempt to run if not under WSL. ---- WHAT COULD GO WRONG: Regressions in this package only affect Ubuntu on the WSL platform. It's features are only leveraged if the user is also running the Ubuntu Pro for WSL on Windows. Otherwise the unit is mostly inert. Changes in the systemd unit could break those invariants. The fix in the logic to detect the Windows user profile folder could break the service for regular user profile folder paths (ASCII-only) if not implemented correctly. Tests confirmed we don't have regressions in that code path. ---- NOTES: * As usual with Go projects vendoring dependencies, a huge part of the diff between the current version and the proposed one is due dependency updates. * The versioning changed to include the 'ubuntu' suffix to differentiate this from Debian native packages, as wsl-pro-service is an Ubuntu-only native package. * The version string now contains the prefix 'wsl-pro-service/' due an implementation detail: certain automations are triggered in the monorepo when tags are pushed based on the pattern of tag string. ** Affects: wsl-pro-service (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2142667 Title: [FFE] wsl-pro-service 0.1.19 into Resolute To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/wsl-pro-service/+bug/2142667/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
