Packaging review MUST: - Package must meet Ubuntu versioning & Maintainer requirements PASS. Version is 1.2.3~us1-0ubuntu1, Maintainer is Ubuntu Developers. - Package must match current Ubuntu (and Debian) packaging policies PASS, some pedantic lintian warnings that can be addressed: P: ghostty: copyright-refers-to-symlink-license usr/share/common-licenses/LGPL Use versioned license, e.g. usr/share/common-licenses/LGPL-2 P: ghostty source: package-does-not-install-examples [zig-vendor/gettext/gettext-tools/examples/] P: ghostty source: package-does-not-install-examples [zig-vendor/gettext/libtextstyle/examples/] P: ghostty source: package-does-not-install-examples [zig-vendor/gtk4_layer_shell/examples/] P: ghostty source: package-does-not-install-examples [zig-vendor/highway/hwy/examples/] P: ghostty source: package-does-not-install-examples [zig-vendor/imgui/examples/] P: ghostty source: package-does-not-install-examples [zig-vendor/libpng/contrib/examples/] P: ghostty source: package-does-not-install-examples [zig-vendor/libxev/examples/] P: ghostty source: package-does-not-install-examples [zig-vendor/libxml2/doc/examples/] P: ghostty source: package-does-not-install-examples [zig-vendor/sentry/examples/] P: ghostty source: package-does-not-install-examples [zig-vendor/zlib/examples/] Exclude examples from vendored sources P: ghostty source: redundant-priority-optional-field [debian/control:3] Priority is optional by default we can omit it. It becomes a warning with Standards Version 4.7.3 P: ghostty source: source-contains-autogenerated-visual-c++-file [zig-vendor/breakpad/src/client/windows/tests/crash_generation_app/crash_generation_app.rc] We can drop windows tests from the vendored sources P: ghostty source: source-contains-prebuilt-binary [zig-vendor/breakpad/src/tools/solaris/dump_syms/testdata/dump_syms_regtest.o] P: ghostty source: source-contains-prebuilt-binary [zig-vendor/sentry/tests/fixtures/libstdc++.so] P: ghostty source: source-contains-prebuilt-binary [zig-vendor/sentry/tests/fixtures/sentry_example] P: ghostty source: source-contains-prebuilt-binary [zig-vendor/sentry/tests/fixtures/with-buildid.so] P: ghostty source: source-contains-prebuilt-binary [zig-vendor/sentry/tests/fixtures/without-buildid-phdr.so] P: ghostty source: source-contains-prebuilt-binary [zig-vendor/sentry/tests/fixtures/without-buildid.so] P: ghostty source: source-contains-prebuilt-java-object [zig-vendor/sentry/.mvn/wrapper/maven-wrapper.jar] P: ghostty source: source-contains-prebuilt-java-object [zig-vendor/sentry/ndk/gradle/wrapper/gradle-wrapper.jar] We can drop tests from the vendored sources Consider adding debian/upstream/metadata (https://dep-team.pages.debian.net/deps/dep12/) - Package must build, install, run, remove, and purge cleanly builds, install/remove - piuparts pass, running works in latests resolute desktop iso, nit: consider disabling info level logging: info: ghostty version=1.2.3-dev+0000000 info: ghostty build optimize=ReleaseFast info: runtime=apprt.Runtime.gtk info: font_backend=font.main.Backend.fontconfig_freetype
SHOULD: - Package should be lintian clean PASS, some pedantic warnings remain - Contents of debian/ should be sane PASS - Changelog should close a "needs-packaging" bug PASS - Package should follow http://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html Could use source/metadata Maintenance review MUST: - Package must contain a watch file or get-orig-source rule PASS - If upstream is no more, the packager should consider adopting the upstream package somewhere N/A - Packages who implement get-orig-source for packages with watch files get extra points N/A, could rename get-orig to get-orig-source for the extra points - Packaged version must not have any known security or critical bugs PASS, security tracker https://github.com/ghostty-org/ghostty/security SHOULD: - Packaging scripts should be readable and readily comprehensible PASS - Upstream should be responsive, and maintain a bug tracker PASS, https://github.com/ghostty-org/ghostty/issues - Packaged version should be latest upstream PASS, v1.2.3 is latest - Package should not be native without an approved spec PASS, not a native package Suitability review MUST: - Package must meet copyright / licensing requirements Some differences reported for vendored code, e.g. GPL-licensed code has MIT copyright in d/copyright. See attached lrc.log. - Non-native packages must have verifiable cryptographic path to upstream source N/A, upstream signs tags, but we also vendor sources with zig fetch, that does not validate dependency signatures. - Package must be advocated by at least two members of ubuntu-dev (the packager may count as one) First review SHOULD: - Package should work on a standard Ubuntu/Kubuntu/Xubuntu/etc. system PASS - Package should provide hints to system services (app-install-data, menus, etc.) to ease installation and use PASS, upstream build generates .desktop files. We install them to /usr/share/applications - Package should provide Ubuntu-specific documentation for variances in behaviour from upstream PASS, provides README.Debian with some workarounds - Package should provide a Homepage: header in debian/control PASS ** Attachment added: "lrc.log" https://bugs.launchpad.net/ubuntu/+bug/2139393/+attachment/5948815/+files/lrc.log -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2139393 Title: [needs-packaging] ghostty To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+bug/2139393/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
