After kernel 6.19, as explained, a cast must be modified. After doing
that, everything compiles and runs as expected

Tested on a Resolute VM with Kernel 7.0.0.3 running and 6.19.0-6.6
headers for double testing, as autopkgtest was failing on the Debian
merge request for kernel 6.19.

Patch has been uploaded to salsa as well, MR can be found here
[ https://salsa.debian.org/debian/iptables-netflow/-/merge_requests/5 ]


We might need to sync in the future once Debian accepts the pushed merge 
request.

Test script:
=====================================================================================================
set +e

iptables -F
rmmod ipt_NETFLOW
dpkg -i iptables-netflow-dkms_2.6-7.2ubuntu1_amd64.deb
dkms status
modinfo ipt_NETFLOW | grep "filename:"
iptables -A OUTPUT -p icmp -j NETFLOW
ping -c 5 google.com
cat /proc/net/stat/ipt_netflow
iptables -F
rmmod ipt_NETFLOW
apt remove -y iptables-netflow-dkms
=====================================================================================================


Result of the tests in the VM are the following
=====================================================================================================
root@ubuntu-resolute:/home/afaina/dkms/resolute/iptables-netflow-dkms/ubuntu# 
./test.sh 
rmmod: ERROR: Module ipt_NETFLOW is not currently loaded
Selecting previously unselected package iptables-netflow-dkms.
(Reading database ... 171419 files and directories currently installed.)
Preparing to unpack iptables-netflow-dkms_2.6-7.2ubuntu1_amd64.deb ...
Unpacking iptables-netflow-dkms (2.6-7.2ubuntu1) ...
Setting up iptables-netflow-dkms (2.6-7.2ubuntu1) ...
Loading new ipt-netflow/2.6 DKMS files...
Building for 6.19.0-6-generic and 7.0.0-3-generic

Building initial module ipt-netflow/2.6 for 6.19.0-6-generic
Sign command: /usr/bin/kmodsign
Signing key: /var/lib/shim-signed/mok/MOK.priv
Public certificate (MOK): /var/lib/shim-signed/mok/MOK.der

Running the pre_build script... done.
Building module(s)....... done.
Signing module /var/lib/dkms/ipt-netflow/2.6/build/ipt_NETFLOW.ko
Installing /lib/modules/6.19.0-6-generic/updates/dkms/ipt_NETFLOW.ko.zst
Running depmod... done.

Building initial module ipt-netflow/2.6 for 7.0.0-3-generic
Sign command: /usr/bin/kmodsign
Signing key: /var/lib/shim-signed/mok/MOK.priv
Public certificate (MOK): /var/lib/shim-signed/mok/MOK.der

Running the pre_build script... done.
Building module(s)...... done.
Signing module /var/lib/dkms/ipt-netflow/2.6/build/ipt_NETFLOW.ko
Installing /lib/modules/7.0.0-3-generic/updates/dkms/ipt_NETFLOW.ko.zst
Running depmod... done.
ipt-netflow/2.6, 6.19.0-6-generic, x86_64: installed
ipt-netflow/2.6, 7.0.0-3-generic, x86_64: installed
filename:       /lib/modules/7.0.0-3-generic/updates/dkms/ipt_NETFLOW.ko.zst
PING google.com (172.217.168.142) 56(84) bytes of data.
64 bytes from tzmila-af-in-f14.1e100.net (172.217.168.142): icmp_seq=1 ttl=117 
time=72.9 ms
64 bytes from tzmila-af-in-f14.1e100.net (172.217.168.142): icmp_seq=2 ttl=117 
time=65.0 ms
64 bytes from tzmila-af-in-f14.1e100.net (172.217.168.142): icmp_seq=3 ttl=117 
time=69.4 ms
64 bytes from tzmila-af-in-f14.1e100.net (172.217.168.142): icmp_seq=4 ttl=117 
time=72.8 ms
64 bytes from tzmila-af-in-f14.1e100.net (172.217.168.142): icmp_seq=5 ttl=117 
time=65.3 ms

--- google.com ping statistics ---
5 packets transmitted, 5 received, 0% packet loss, time 4007ms
rtt min/avg/max/mdev = 64.995/69.102/72.907/3.447 ms
ipt_NETFLOW 2.6, srcversion F23047161372772B0258EDF; dir mac promisc+mpls samp 
snmp vlan
Protocol version 5 (netflow)
Timeouts: active 1800s, inactive 15s. Maxflows 2000000
Flow sampling is disabled.
Promisc hack is disabled (observed 0 packets, discarded 0).
Flows: active 1 (peak 1 reached 0d0h0m ago), mem 5120K, worker delay 100/1000 
[1..100] (25 ms, 0 us, 1:0 [cpu13]).
Hash: size 655360 (mem 5120K), metric 1.00 [1.00, 1.00, 1.00]. InHash: 5 pkt, 0 
K, InPDU 0, 0.
Rate: 840 bits/sec, 1 packets/sec; Avg 1 min: 105 bps, 0 pps; 5 min: 21 bps, 0 
pps
cpu#     pps; <search found new [metric], trunc frag alloc maxflows>, traffic: 
<pkt, bytes>, drop: <pkt, bytes>
Total      1;      0      4      1 [1.00],    0    0    0    0, traffic: 5, 0 
MB, drop: 0, 0 K
cpu0       0;      0      0      0 [1.00],    0    0    0    0, traffic: 0, 0 
MB, drop: 0, 0 K
cpu1       0;      0      0      0 [1.00],    0    0    0    0, traffic: 0, 0 
MB, drop: 0, 0 K
cpu2       0;      0      0      0 [1.00],    0    0    0    0, traffic: 0, 0 
MB, drop: 0, 0 K
cpu3       0;      0      0      0 [1.00],    0    0    0    0, traffic: 0, 0 
MB, drop: 0, 0 K
cpu4       0;      0      0      0 [1.00],    0    0    0    0, traffic: 0, 0 
MB, drop: 0, 0 K
cpu5       0;      0      0      0 [1.00],    0    0    0    0, traffic: 0, 0 
MB, drop: 0, 0 K
cpu6       0;      0      0      0 [1.00],    0    0    0    0, traffic: 0, 0 
MB, drop: 0, 0 K
cpu7       0;      0      0      0 [1.00],    0    0    0    0, traffic: 0, 0 
MB, drop: 0, 0 K
cpu8       0;      0      0      0 [1.00],    0    0    0    0, traffic: 0, 0 
MB, drop: 0, 0 K
cpu9       0;      0      0      0 [1.00],    0    0    0    0, traffic: 0, 0 
MB, drop: 0, 0 K
cpu10      0;      0      0      0 [1.00],    0    0    0    0, traffic: 0, 0 
MB, drop: 0, 0 K
cpu11      0;      0      0      0 [1.00],    0    0    0    0, traffic: 0, 0 
MB, drop: 0, 0 K
cpu12      0;      0      0      0 [1.00],    0    0    0    0, traffic: 0, 0 
MB, drop: 0, 0 K
cpu13      0;      0      0      0 [1.00],    0    0    0    0, traffic: 0, 0 
MB, drop: 0, 0 K
cpu14      0;      0      0      0 [1.00],    0    0    0    0, traffic: 0, 0 
MB, drop: 0, 0 K
cpu15      1;      0      4      1 [1.00],    0    0    0    0, traffic: 5, 0 
MB, drop: 0, 0 K
Export: Rate 0 bytes/s; Total 0 pkts, 0 MB, 0 flows; Errors 0 pkts; Traffic 
lost 0 pkts, 0 Kbytes, 0 flows.
sock0: 127.0.0.1:2055, sndbuf 212992, filled 1, peak 0; err: sndbuf reached 0, 
connect 0, cberr 0, other 0
The following packages were automatically installed and are no longer required:
  linux-modules-7.0.0-1-generic  linux-unstable-headers-7.0.0-1
Use 'apt autoremove' to remove them.

REMOVING:
  iptables-netflow-dkms

Summary:
  Upgrading: 0, Installing: 0, Removing: 1, Not Upgrading: 132
  Freed space: 304 kB

(Reading database ... 171438 files and directories currently installed.)
Removing iptables-netflow-dkms (2.6-7.2ubuntu1) ...
Module ipt-netflow/2.6 for kernel 6.19.0-6-generic (x86_64):
Before uninstall, this module version was ACTIVE on this kernel.
Deleting /lib/modules/6.19.0-6-generic/updates/dkms/ipt_NETFLOW.ko.zst
Running depmod... done.

Module ipt-netflow/2.6 for kernel 7.0.0-3-generic (x86_64):
Before uninstall, this module version was ACTIVE on this kernel.
Deleting /lib/modules/7.0.0-3-generic/updates/dkms/ipt_NETFLOW.ko.zst
Running depmod... done.

Deleting module ipt-netflow/2.6 completely from the DKMS tree.
Scanning processes...                                                           
                                  
Scanning linux images...                                                        
                                  

Running kernel seems to be up-to-date.

No services need to be restarted.

No containers need to be restarted.

No user sessions are running outdated binaries.

No VM guests are running outdated hypervisor (qemu) binaries on this host.
root@ubuntu-resolute:/home/afaina/dkms/resolute/iptables-netflow-dkms/ubuntu#
=====================================================================================================


autopkgtest results:
=====================================================================================================
I: Testing if ipt-netflow modules are correctly installed.
ipt-netflow/2.6, 6.19.0-9-generic, x86_64: installed
I: Trying to build ipt-netflow/2.6 for 7.0.0-3-generic
I: Testing if ipt-netflow modules are correctly installed.
ipt-netflow/2.6/7.0.0-3-generic/x86_64/log/make.log
ipt-netflow/2.6/6.19.0-9-generic/x86_64/log/make.log
ipt-netflow/2.6, 7.0.0-3-generic, x86_64: installed
I: Summary:
I: PASS ipt-netflow/2.6 6.19.0-9-generic
I: PASS ipt-netflow/2.6 7.0.0-3-generic
autopkgtest [17:24:23]: test dkms-autopkgtest: -----------------------]
autopkgtest [17:24:24]: test dkms-autopkgtest:  - - - - - - - - - - results - - 
- - - - - - - -
dkms-autopkgtest     PASS (superficial)
autopkgtest [17:24:24]: @@@@@@@@@@@@@@@@@@@@ summary
dkms-autopkgtest     PASS (superficial)
=====================================================================================================

** Patch added: "dkms_patch_resolute.patch"
   
https://bugs.launchpad.net/ubuntu/+source/iptables-netflow/+bug/2143742/+attachment/5951055/+files/dkms_patch_resolute.patch

** Changed in: iptables-netflow (Ubuntu Resolute)
       Status: New => In Progress

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2143742

Title:
  Failure to build in Resolute - Kernel 6.19 and 7.0

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/iptables-netflow/+bug/2143742/+subscriptions


-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to