Hello all, interested,
I did quite a bit of rework/re-review and I think I addressed the
leftover issues mentioned here:
https://bugs.launchpad.net/ubuntu/+bug/2133814/comments/32
With one exception of still having amd_comgr in usr/lib/{triplet}/ . I
am a bit reluctant to encapsulate this in /usr/lib/rocm like the others
for these reasons;
1. This amd_comgr is being used hardcoded without an easy way to customize its
path in some of the libraries I see in rocm stack and I am not sure how many of
these packages we have to be honest (need to probe a couple to see the impact)
2. I did a quick search on comgr and it looks like there no one really
providing a library/binary with similar name to comgr (except libemos-dev 99.9%
percent not relevant)
```
$ sudo apt-file find comgr
libamd-comgr-dev: /usr/include/amd_comgr/amd_comgr.h
libamd-comgr-dev:
/usr/lib/x86_64-linux-gnu/cmake/amd_comgr/amd_comgr-config-version.cmake
libamd-comgr-dev:
/usr/lib/x86_64-linux-gnu/cmake/amd_comgr/amd_comgr-config.cmake
libamd-comgr-dev:
/usr/lib/x86_64-linux-gnu/cmake/amd_comgr/amd_comgr-targets-none.cmake
libamd-comgr-dev:
/usr/lib/x86_64-linux-gnu/cmake/amd_comgr/amd_comgr-targets.cmake
libamd-comgr-dev: /usr/lib/x86_64-linux-gnu/libamd_comgr.so
libamd-comgr-dev: /usr/share/doc/libamd-comgr-dev/changelog.Debian.gz
libamd-comgr-dev: /usr/share/doc/libamd-comgr-dev/copyright
libamd-comgr2: /usr/lib/x86_64-linux-gnu/libamd_comgr.so.2
libamd-comgr2: /usr/lib/x86_64-linux-gnu/libamd_comgr.so.2.6.0
libamd-comgr2: /usr/share/doc/libamd-comgr2/changelog.Debian.gz
libamd-comgr2: /usr/share/doc/libamd-comgr2/copyright
libamd-comgr3: /usr/lib/x86_64-linux-gnu/libamd_comgr.so.3
libamd-comgr3: /usr/lib/x86_64-linux-gnu/libamd_comgr.so.3.0.0
libamd-comgr3: /usr/share/doc/libamd-comgr3/changelog.Debian.gz
libamd-comgr3: /usr/share/doc/libamd-comgr3/copyright
libemos-dev: /usr/include/gribex/comgrb.h
```
Other highlights on the changes I made:
- I updated the lintian-overrides mostly aligning with llvm-toolchain-21, only
skipping the P: and X: messages
- Used "Native" target together with AMDGPU instead of hardcoded X86, as per my
research X86 target would handle variants well but just to be on safe side for
amd64v3, used Native so hoping upstream to handle correctly.
- Removed wasm libraries (there are only header files scattered around around 3
(as far as I remember) )
- Fixed copyright issues, did spent quite amount of time to figure out dual
licensing stuff but it looks good to me with its current state.
- Combined all the changelog entries that are not really released in ubuntu to
preserve clean history, giving credits to contributors as well.
Latest codebase for packaging has been pushed to:
https://code.launchpad.net/~bullwinkle-team/ubuntu/+source/llvm-toolchain-rocm/+git/llvm-toolchain-rocm/+ref/ubuntu/devel
PPA with the package build (hopefully available soon) will be here:
https://launchpad.net/~tchavadar/+archive/ubuntu/lp2133814
See all my changes: (for details please look the commit diff)
```
commit 98dac3f35b10854977be2a568e476c6844b58f27
Author: Talha Can Havadar <[email protected]>
Date: Wed Mar 11 22:38:42 2026 +0100
d/control: add VCS information
commit 48335e2729b747e4801b1fda6b68ab0034ab5ecb
Author: Talha Can Havadar <[email protected]>
Date: Tue Mar 10 14:45:18 2026 +0100
d/control: upgrade standards-version and at myself as uploader
commit 840c7923c452aad5709f917dad15be51b23b4282
Author: Talha Can Havadar <[email protected]>
Date: Tue Mar 10 14:45:18 2026 +0100
d/s/lintian-overrides: add lintian-overrides for false negatives
commit 5770906cc112e80b8a9db92ee91e0e75c2439402
Author: Talha Can Havadar <[email protected]>
Date: Tue Mar 10 14:45:18 2026 +0100
d/{libamd-comgr*.in, rules}: use multiarch as install location
commit 248b3c409d3ec39007ec56f52ed9319bdcd7fb11
Author: Talha Can Havadar <[email protected]>
Date: Tue Mar 10 14:45:18 2026 +0100
d/amd-device-libs-rocm.install.in: use debian multiarch for
installation
commit 21c6452ff6ddf7ec0bfad2ac9603870551c78946
Author: Talha Can Havadar <[email protected]>
Date: Tue Mar 10 14:45:18 2026 +0100
d/rules: enable Native as build target instead of X86
Instead of only building for X86 and AMDGPU targets, we are not building
for Native and AMDGPU targets, this gives more flexibility to us and
improves future maintainability of the package.
Gbp-Dch: full
commit 767bfb79cb79371da964be64862f92e6d7f54648
Author: Talha Can Havadar <[email protected]>
Date: Tue Mar 10 14:45:18 2026 +0100
d/s/options: ignore .jj as it is a vcs directory
commit 3eccaca453356628846be8ec5ddff15d417c31a6
Author: Talha Can Havadar <[email protected]>
Date: Tue Mar 10 14:45:18 2026 +0100
d/{liblld, lld, not-installed}: do not install wasm libraries
As wasm is not concern of ROCm we are itentionally not installing it
into the system, please justify if this is needed in the future
Gbp-Dch: full
commit 3bc5ac5e4b3ec5eb45972d246b9354ea73e1b8fa
Author: Talha Can Havadar <[email protected]>
Date: Tue Mar 10 14:45:18 2026 +0100
d/copyright: rework
- added copyright owners for debian files based on changelog
- fixed comment section issue at top
- removed superfluous copyright files
- corrected dual licensing for some files see commit diff for details
commit 218bcc38d2435a2d18997392e369c025b412513e
Author: Talha Can Havadar <[email protected]>
Date: Tue Mar 10 14:45:18 2026 +0100
debian: wrap-and-sort, some hygiene
```
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2133814
Title:
NEW package request: llvm-toolchain-rocm
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+bug/2133814/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
