Packaging review MUST: - Package must meet Ubuntu versioning & Maintainer requirements PASS (Ubuntu Developers, ) - Package must match current Ubuntu (and Debian) packaging policies PASS - Package must build, install, run, remove, and purge cleanly PASS 3m6.1s INFO: PASS: All tests. 3m6.1s INFO: piuparts run ends.
SHOULD: - Package should be lintian clean Some warnings (should be fixed) W: directxshadercompiler source: mismatched-override unpack-message-for-orig *test/Object/Inputs/thin-path.a* [debian/source/lintian-overrides:13] W: directxshadercompiler source: mismatched-override unpack-message-for-source ar failed for test/Object/Inputs/thin-path.a [debian/source/lintian-overrides:14] W: dxc: mismatched-override spelling-error-in-binary TAht That [usr/lib/dxc/libdxcompiler.so] [usr/share/lintian/overrides/dxc:2] W: dxc: mismatched-override spelling-error-in-binary TeH The [usr/lib/dxc/libdxcompiler.so] [usr/share/lintian/overrides/dxc:3] Pendantic messages (nice to fix) P: directxshadercompiler source: package-does-not-install-examples [examples/] P: directxshadercompiler source: package-does-not-install-examples [tools/clang/bindings/python/examples/] P: directxshadercompiler source: package-does-not-install-examples [tools/clang/examples/] P: directxshadercompiler source: package-does-not-install-examples [utils/lit/examples/] - Contents of debian/ should be sane Nice to fix - d/copyright mentions some missing files: ** Superfluous file pattern include/llvm/Support/ConvertUTF.h ** Superfluous file pattern lib/Support/ConvertUTF.c ** Superfluous file pattern include/llvm/Support/MD5.h ** Superfluous file pattern lib/Support/MD5.cpp ** Superfluous file pattern lib/Fuzzer/FuzzerSHA1.cpp ** Superfluous file pattern lib/Support/regstrlcpy.c ** Superfluous file pattern utils/git/code-format-helper.py ** Superfluous file pattern utils/git/code-format-save-diff.py ** Superfluous file pattern tools/clang/lib/Headers/hlsl/README.txt ** Superfluous file pattern include/dxc/Support/d3dx12.h Question/nit/no action: dxc-dev package installs some llvm*.a static libraries and we delete some of those to match upstream distribution. Is there a way to automate it? Consider adding a smoke test to d/tests, e.g. compiling a shader with dxc nit/no action: the usage outputs dxc.exe: /usr/bin/dxc-3.7 -help OVERVIEW: HLSL Compiler for Linux Version: libdxcompiler.so: 1.9(0-00000000)(1.9.2602.0) USAGE: dxc.exe [options] <inputs> Consider opening PR upstream to use an actual executable name. - Changelog should close a "needs-packaging" bug PASS - Package should follow http://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html PASS Maintenance review MUST: - Package must contain a watch file or get-orig-source rule PASS - If upstream is no more, the packager should consider adopting the upstream package somewhere N/A - Packages who implement get-orig-source for packages with watch files get extra points N/A - Packaged version must not have any known security or critical bugs No published advisories: https://github.com/microsoft/DirectXShaderCompiler/security SHOULD: - Packaging scripts should be readable and readily comprehensible PASS - Upstream should be responsive, and maintain a bug tracker PASS, https://github.com/microsoft/DirectXShaderCompiler/issues - Packaged version should be latest upstream PASS, 1.9.2602 - Package should not be native without an approved spec N/a Suitability review MUST: - Package must meet copyright / licensing requirements PASS - Non-native packages must have verifiable cryptographic path to upstream source Consider updating watch file to include signature validation: --- Pgp-Mode: gittag --- and add upstream signing key: -- gpg --keyserver hkps://keyserver.ubuntu.com --recv-keys B5690EEEBB952194 && gpg --armor --export B5690EEEBB952194 > debian/signing-key.asc --- - Package must be advocated by at least two members of ubuntu-dev (the packager may count as one) First review SHOULD: - Package should work on a standard Ubuntu/Kubuntu/Xubuntu/etc. system PASS: /usr/bin/dxc-3.7 --version libdxcompiler.so: 1.9(0-00000000)(1.9.2602.0) dx compiler is reachable - Package should provide hints to system services (app-install-data, menus, etc.) to ease installation and use N/A - Package should provide Ubuntu-specific documentation for variances in behaviour from upstream see debian/README.sources on differences from upstream sources. There is no behaviour changes vs upstream. - Package should provide a Homepage: header in debian/control PASS -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2127245 Title: [needs-packaging] directxshadercompiler To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+bug/2127245/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
