** Description changed: [Impact] On Dell systems, the original Panel Replay quirk was matched using a hard-coded PCI device ID (0xb080). Dell ships the same display panel (DA14260) with different device IDs across hardware revisions. Systems with a device ID other than 0xb080 do not hit the quirk, so Panel Replay is not disabled and the display FPS drops permanently after suspend/resume. This is a follow-up to the fix in bug 2144712. [Fix] Replace the hard-coded device ID 0xb080 in the Dell XPS 14 DA14260 quirk entry with a new DEVICE_ID_ANY sentinel (value 0). Update intel_init_quirks() to skip the device ID check when DEVICE_ID_ANY is set, matching only on subsystem vendor (0x1028), subsystem device (0x0db9), and sink OUI (0x00:0x22:0xb9). The patch is under review in the Intel DRM/i915 mailing list: - https://patchwork.freedesktop.org/patch/712905/ + https://patchwork.freedesktop.org/patch/713065/ Fixes: 45c77d4bf8d4 ("drm/i915/psr: Disable Panel Replay on Dell XPS 14 DA14260 as a quirk") [Test Plan] On a Dell system (CID: 202511-38076) with Intel integrated graphics: Suspend and resume 5 times: - $ sudo rtcwake -m mem -s 20 + $ sudo rtcwake -m mem -s 20 After each resume, drag a window around the desktop and check the frame rate. Without the patch: systems with a device ID other than 0xb080 do not hit the quirk — display FPS drops permanently after resume. With the patch: the quirk applies regardless of device ID — display stays at normal 120Hz after suspend/resume. [Where problems could occur] Could break Panel Replay on Intel i915 systems. The DEVICE_ID_ANY change makes the quirk match on subsystem vendor/device and sink OUI only. If a future Dell panel ships with the same subsystem IDs but does not have the Panel Replay regression, Panel Replay will be silently disabled on it. Users would see slightly higher power consumption on OLED panels with no error in dmesg. Also, the updated match logic in intel_init_quirks() adds an OR branch for DEVICE_ID_ANY. A bug there could cause the quirk to not fire at all (regression returns) or fire too broadly (Panel Replay disabled on unaffected systems). [Other Info] The patch is under review in the Intel DRM mailing list (patchwork patch - 712905) and has not yet landed in mainline. + 713065) and has not yet landed in mainline. This is a follow-up to the fix committed for bug 2144712. Both patches must be present for full coverage across all Dell hardware revisions.
-- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2145172 Title: On Dell systems, the internal OLED display drops to a visibly low FPS after suspend/resume due to hard-coded device ID in Panel Replay quirk To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2145172/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
