Public bug reported: [Impact]
rocsolver 7.1.1 is a bug-fix update over 7.1.0, including: - Buffer overflow in dot device function (LP: #2144027): an out-of-bounds shared-memory write in the dot reduction kernel could corrupt memory and cause incorrect results or ASAN failures in any routine that calls it (e.g. larf, larfg). - Missing <cassert> include in lib_device_helpers.hpp: compilation could fail on certain toolchain configurations. - Performance improvement: device properties are now read from the cached rocblas_handle instead of being queried on each call, reducing overhead in larf, larfg, larft, steqr, geqr2, gesdd, and sytd2/hetd2. Still, there were no changes to API calls and no symbols were added/removed, which means this update should not impact any linking or other libraries that might depend on this one. [Test Plan] As expected from previous version 7.1.0, rocsolver ships two separate test groups, one for the main/deterministic tests and other group for flaky tests, as stated on a couple of the upstream comments: https://github.com/ROCm/rocSOLVER/blob/1c0b9750d9c60f0ccb91987db7b570f116f296fa/library/src/auxiliary/rocauxiliary_larfg.hpp#L176. This way, after the update, the resuts of autopkgtests on this package are still correctly handled by the group separation, which further demonstrates that the library behavior regarding tests is kept the same: ``` [----------] Global test environment tear-down [==========] 3688 tests from 30 test suites ran. (175807 ms total) [ PASSED ] 3683 tests. [ FAILED ] 5 tests, listed below: [ FAILED ] checkin_lapack/POTRF.batched__float_complex/10, where GetParam() = ({ 50, 50, 1 }, L) [ FAILED ] checkin_lapack/POTRF_64.strided_batched__float_complex/11, where GetParam() = ({ 50, 50, 1 }, U) [ FAILED ] daily_lapack/SYGVDJ.strided_batched__float/0, where GetParam() = ({ 192, 192, 192, 0 }, { 1, N, U }) [ FAILED ] daily_lapack/SYGVDJ.strided_batched__float/16, where GetParam() = ({ 300, 300, 310, 0 }, { 2, V, U }) [ FAILED ] daily_lapack/SYGVDX.strided_batched__float/12, where GetParam() = ({ 300, 300, 310, 320, -15, -10, 20, 30, 0 }, { 1, N, A, U }) 5 FAILED TESTS rocSOLVER version 3.31.0.47780c8-dirty (with rocBLAS 5.1.0.) autopkgtest [19:40:09]: test librocsolver0-tests-flaky: -----------------------] autopkgtest [19:40:10]: test librocsolver0-tests-flaky: - - - - - - - - - - results - - - - - - - - - - librocsolver0-tests-flaky FLAKY non-zero exit status 1 autopkgtest [19:40:10]: @@@@@@@@@@@@@@@@@@@@ summary librocsolver0-tests-main PASS librocsolver0-tests-flaky FLAKY non-zero exit status 1 ``` [Where problems could occur] - Potential regressions coming from memory management changes and numerical stability fixes in core linear algebra kernels (specifically eigensolvers and warp-level reductions), which means that inside the 'flaky' tests a couple more errors might start to happen due to their non-deterministic behavior. [ Other Info ] * This update is part of the coordinated ROCm stack release to bump all of its parts to version 7.1.1 after their initial 7.1.0 packaging. * PPA: https://launchpad.net/~bullwinkle-team/+archive/ubuntu/rocm- devel-21/+packages * Upstream version comparison: https://github.com/ROCm/rocSOLVER/compare/rocm-7.1.0...rocm-7.1.1 ** Affects: rocsolver (Ubuntu) Importance: Undecided Assignee: Bruno Bernardo de Moura (bruno-bdmoura) Status: New ** Changed in: rocsolver (Ubuntu) Assignee: (unassigned) => Bruno Bernardo de Moura (bruno-bdmoura) ** Description changed: - [Impact] + [Impact] rocsolver 7.1.1 is a bug-fix update over 7.1.0, including: - - Buffer overflow in dot device function (LP: #2144027): an out-of-bounds shared-memory write in the dot reduction kernel could corrupt memory and cause incorrect results or ASAN failures - in any routine that calls it (e.g. larf, larfg). - - Missing <cassert> include in lib_device_helpers.hpp: compilation could fail on certain toolchain configurations. - - Performance improvement: device properties are now read from the cached rocblas_handle instead of being queried on each call, reducing overhead in larf, larfg, larft, steqr, geqr2, - gesdd, and sytd2/hetd2. + - Buffer overflow in dot device function (LP: #2144027): an out-of-bounds shared-memory write in the dot reduction kernel could corrupt memory and cause incorrect results or ASAN failures in any routine that calls it (e.g. larf, larfg). + - Missing <cassert> include in lib_device_helpers.hpp: compilation could fail on certain toolchain configurations. + - Performance improvement: device properties are now read from the cached rocblas_handle instead of being queried on each call, reducing overhead in larf, larfg, larft, steqr, geqr2, gesdd, and sytd2/hetd2. - Still, there were no changes to API calls and no symbols were added/removed, which means this update should not impact any linking - or other libraries that might depend on this one. + Still, there were no changes to API calls and no symbols were + added/removed, which means this update should not impact any linking or + other libraries that might depend on this one. - [Test Plan] + [Test Plan] - As expected from previous version 7.1.0, rocsolver ships two separate test groups, one for the main and deterministic tests and other group - for flaky tests, as stated on a couple of the upstream comments: https://github.com/ROCm/rocSOLVER/blob/1c0b9750d9c60f0ccb91987db7b570f116f296fa/library/src/auxiliary/rocauxiliary_larfg.hpp#L176. - This way, to after the update, the resuts of autopkgtests on this package are still correctly handled by the group separation, which further demonstrates that - the library behavior regarding tests is kept the same: + As expected from previous version 7.1.0, rocsolver ships two separate + test groups, one for the main/deterministic tests and other group for + flaky tests, as stated on a couple of the upstream comments: + https://github.com/ROCm/rocSOLVER/blob/1c0b9750d9c60f0ccb91987db7b570f116f296fa/library/src/auxiliary/rocauxiliary_larfg.hpp#L176. - ``` - [----------] Global test environment tear-down - [==========] 3688 tests from 30 test suites ran. (175807 ms total) - [ PASSED ] 3683 tests. - [ FAILED ] 5 tests, listed below: - [ FAILED ] checkin_lapack/POTRF.batched__float_complex/10, where GetParam() = ({ 50, 50, 1 }, L) - [ FAILED ] checkin_lapack/POTRF_64.strided_batched__float_complex/11, where GetParam() = ({ 50, 50, 1 }, U) - [ FAILED ] daily_lapack/SYGVDJ.strided_batched__float/0, where GetParam() = ({ 192, 192, 192, 0 }, { 1, N, U }) - [ FAILED ] daily_lapack/SYGVDJ.strided_batched__float/16, where GetParam() = ({ 300, 300, 310, 0 }, { 2, V, U }) - [ FAILED ] daily_lapack/SYGVDX.strided_batched__float/12, where GetParam() = ({ 300, 300, 310, 320, -15, -10, 20, 30, 0 }, { 1, N, A, U }) + This way, after the update, the resuts of autopkgtests on this package are still correctly handled by the group separation, which further demonstrates that + the library behavior regarding tests is kept the same: - 5 FAILED TESTS - rocSOLVER version 3.31.0.47780c8-dirty (with rocBLAS 5.1.0.) - autopkgtest [19:40:09]: test librocsolver0-tests-flaky: -----------------------] - autopkgtest [19:40:10]: test librocsolver0-tests-flaky: - - - - - - - - - - results - - - - - - - - - - - librocsolver0-tests-flaky FLAKY non-zero exit status 1 - autopkgtest [19:40:10]: @@@@@@@@@@@@@@@@@@@@ summary - librocsolver0-tests-main PASS - librocsolver0-tests-flaky FLAKY non-zero exit status 1 - ``` + ``` + [----------] Global test environment tear-down + [==========] 3688 tests from 30 test suites ran. (175807 ms total) + [ PASSED ] 3683 tests. + [ FAILED ] 5 tests, listed below: + [ FAILED ] checkin_lapack/POTRF.batched__float_complex/10, where GetParam() = ({ 50, 50, 1 }, L) + [ FAILED ] checkin_lapack/POTRF_64.strided_batched__float_complex/11, where GetParam() = ({ 50, 50, 1 }, U) + [ FAILED ] daily_lapack/SYGVDJ.strided_batched__float/0, where GetParam() = ({ 192, 192, 192, 0 }, { 1, N, U }) + [ FAILED ] daily_lapack/SYGVDJ.strided_batched__float/16, where GetParam() = ({ 300, 300, 310, 0 }, { 2, V, U }) + [ FAILED ] daily_lapack/SYGVDX.strided_batched__float/12, where GetParam() = ({ 300, 300, 310, 320, -15, -10, 20, 30, 0 }, { 1, N, A, U }) + 5 FAILED TESTS + rocSOLVER version 3.31.0.47780c8-dirty (with rocBLAS 5.1.0.) + autopkgtest [19:40:09]: test librocsolver0-tests-flaky: -----------------------] + autopkgtest [19:40:10]: test librocsolver0-tests-flaky: - - - - - - - - - - results - - - - - - - - - - + librocsolver0-tests-flaky FLAKY non-zero exit status 1 + autopkgtest [19:40:10]: @@@@@@@@@@@@@@@@@@@@ summary + librocsolver0-tests-main PASS + librocsolver0-tests-flaky FLAKY non-zero exit status 1 + ``` - [Where problems could occur] + [Where problems could occur] - - Potential regressions coming from memory management changes and numerical stability fixes in core linear algebra kernels - (specifically eigensolvers and warp-level reductions), which means that inside the 'flaky' tests a couple more errors might start to - happen due to their non-deterministic behavior. + - Potential regressions coming from memory management changes and + numerical stability fixes in core linear algebra kernels (specifically + eigensolvers and warp-level reductions), which means that inside the + 'flaky' tests a couple more errors might start to happen due to their + non-deterministic behavior. - [ Other Info ] + [ Other Info ] - * This update is part of the coordinated ROCm stack release to bump all + * This update is part of the coordinated ROCm stack release to bump all of its parts to version 7.1.1 after their initial 7.1.0 packaging. - * PPA: https://launchpad.net/~bullwinkle-team/+archive/ubuntu/rocm- - exp-21/+packages + * PPA: https://launchpad.net/~bullwinkle-team/+archive/ubuntu/rocm- + devel-21/+packages - * Upstream version comparison: + * Upstream version comparison: https://github.com/ROCm/rocSOLVER/compare/rocm-7.1.0...rocm-7.1.1 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2151823 Title: SRU: New upstream version 7.1.1 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/rocsolver/+bug/2151823/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
