### Packaging review
MUST:
- [Pass] Package must meet Ubuntu versioning & Maintainer requirements
- [Fail] Package must match current Ubuntu (and Debian) packaging policies
- d/control: Should it be architecture any?
- d/control: Missing Vcs-Browser / Vcs-Git
- d/control: MultiArch flags missing
- d/control: Description in source stanza, which is non-standard.
See
https://www.debian.org/doc/debian-policy/ch-controlfields.html#debian-source-package-template-control-files-debian-control
- d/rules: tab/whitespace mixed
- d/rules: drop DH_GOPKG, it is set by dh-golang from d/control
XS-Go-Import-Path
https://lintian.debian.org/tags/missing-xs-go-import-path-for-golang-package.html
- nvidia-container-toolkit-base: should it also replace
nvidia-container-toolkit?
Note: this is compatibility with upstream packaging, the package
nvidia-container-runtime
was never admitted to Debian archive. Maybe comment it d/control?
Need second opinion here.
- notice files are not installed:
E: nvidia-container-toolkit source:
missing-notice-file-for-apache-license [tests/vendor/go.yaml.in/yaml/v3/NOTICE]
E: nvidia-container-toolkit source:
missing-notice-file-for-apache-license
[vendor/github.com/opencontainers/runc/NOTICE]
E: nvidia-container-toolkit source:
missing-notice-file-for-apache-license
[vendor/google.golang.org/grpc/NOTICE.txt]
E: nvidia-container-toolkit source:
missing-notice-file-for-apache-license [vendor/gopkg.in/yaml.v3/NOTICE]
E: nvidia-container-toolkit source:
missing-notice-file-for-apache-license
[vendor/sigs.k8s.io/yaml/goyaml.v2/NOTICE]
W: nvidia-container-toolkit source: mismatched-override
very-long-line-length-in-source-file 43425 > 512
[testdata/lookup/rootfs-2/etc/ld.so.cache:1]
[debian/source/lintian-overrides:16]
W: nvidia-container-toolkit source: mismatched-override
very-long-line-length-in-source-file 44091 > 512
[testdata/lookup/rootfs-1/etc/ld.so.cache:8]
[debian/source/lintian-overrides:17]
- deployments/systemd/nvidia-cdi-refresh.env - should be installed as
conffile:
https://www.debian.org/doc/debian-policy/ch-files.html#configuration-files
- debian/nvidia-cdi-hook.manpages,
debian/nvidia-container-runtime.manpages:
looks like a leftover from the previous package version.
- d/watch: do we need Repacksuffix: +dfsg?
- [Pass] Package must build, install, run, remove, and purge cleanly
SHOULD:
- [Fail] Package should be lintian clean
E: nvidia-container-toolkit source:
missing-notice-file-for-apache-license [tests/vendor/go.yaml.in/yaml/v3/NOTICE]
E: nvidia-container-toolkit source:
missing-notice-file-for-apache-license
[vendor/github.com/opencontainers/runc/NOTICE]
E: nvidia-container-toolkit source:
missing-notice-file-for-apache-license
[vendor/google.golang.org/grpc/NOTICE.txt]
E: nvidia-container-toolkit source:
missing-notice-file-for-apache-license [vendor/gopkg.in/yaml.v3/NOTICE]
E: nvidia-container-toolkit source:
missing-notice-file-for-apache-license
[vendor/sigs.k8s.io/yaml/goyaml.v2/NOTICE]
W: nvidia-container-toolkit source: mismatched-override
very-long-line-length-in-source-file 43425 > 512
[testdata/lookup/rootfs-2/etc/ld.so.cache:1]
[debian/source/lintian-overrides:16]
W: nvidia-container-toolkit source: mismatched-override
very-long-line-length-in-source-file 44091 > 512
[testdata/lookup/rootfs-1/etc/ld.so.cache:8]
[debian/source/lintian-overrides:17]
- [Pass] Contents of debian/ should be sane
- debian/nvidia-container-toolkit-base.postinst - ignores start errors
deb-systemd-helper enable nvidia-cdi-refresh.path || echo "Warning:
Failed to enable nvidia-cdi-refresh.path" >&2
- [Pass] Changelog should close a "needs-packaging" bug
- [Pass] Package should follow
http://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html
### Maintenance review
- [Pass] Package must contain a watch file or get-orig-source rule
- [n/a] If upstream is no more, the packager should consider adopting the
upstream package somewhere
- [n/a] Packages who implement get-orig-source for packages with watch files
get extra points
- [Pass] Packaged version must not have any known security or critical bugs
https://github.com/NVIDIA/nvidia-container-toolkit/security
SHOULD:
- [Pass] Packaging scripts should be readable and readily comprehensible
- [Pass] Upstream should be responsive, and maintain a bug tracker
https://github.com/NVIDIA/nvidia-container-toolkit
- [Fail] Packaged version should be latest upstream
Latest is 1.19.1
https://github.com/NVIDIA/nvidia-container-toolkit/releases/tag/v1.19.1
- [n/a] Package should not be native without an approved spec
### Suitability review
MUST:
- [Fail] Package must meet copyright / licensing requirements.
en: Versions: licenserecon '11.0' licensecheck '3.3.9-1ubuntu2'
Parsing Source Tree ....
Reading d/copyright ....
Running licensecheck ....
d/copyright | licensecheck
Apache-2.0 | Expat
tests/vendor/github.com/go-task/slim-sprig/v3/LICENSE.txt
Apache-2.0 | Apache-2.0 and/or Expat
tests/vendor/github.com/pelletier/go-toml/LICENSE
BSD-3-Clause | OpenSSL
tests/vendor/golang.org/x/crypto/chacha20/chacha_ppc64x.s
Apache-2.0 | Apache-2.0 and/or Expat
tests/vendor/go.yaml.in/yaml/v3/LICENSE
MPL-2.0 | BSD-3-clause
vendor/github.com/cyphar/filepath-securejoin/LICENSE.BSD
Apache-2.0 | BSD-3-clause vendor/github.com/golang/protobuf/LICENSE
Apache-2.0 | Expat
vendor/github.com/knqyf263/go-plugin/LICENSE
BSD-3-Clause | BSD-2-clause
vendor/github.com/moby/sys/capability/LICENSE
Apache-2.0 | BSD-3-clause
vendor/github.com/moby/sys/symlink/LICENSE.BSD
Apache-2.0 | BSD-3-clause vendor/github.com/NVIDIA/go-nvlib/NOTICE
Expat | Apache-2.0 and/or Expat
vendor/github.com/pelletier/go-toml/LICENSE
Apache-2.0 | Apache-2.0 and/or Expat vendor/gopkg.in/yaml.v3/LICENSE
Apache-2.0 | Expat
vendor/sigs.k8s.io/yaml/goyaml.v2/LICENSE.libyaml
Apache-2.0 | BSD-3-clause and/or Expat vendor/sigs.k8s.io/yaml/LICENSE
- [Pass] Non-native packages must have verifiable cryptographic path to
upstream source
Upstream uses signed tags
- [n/a] Package must be advocated by at least two members of ubuntu-dev (the
packager may count as one).
Fist Review
SHOULD:
- [Pass] Package should work on a standard Ubuntu/Kubuntu/Xubuntu/etc. system
- [n/a] Package should provide hints to system services (app-install-data,
menus, etc.) to ease installation and use
This is not a desktop application.
- [n/a] Package should provide Ubuntu-specific documentation for variances in
behaviour from upstream
No variance from upstream
- [Pass] Package should provide a Homepage: header in debian/control
Homepage: https://github.com/NVIDIA/nvidia-container-toolkit
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2138390
Title:
[needs-packaging] nvidia-container-toolkit
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+bug/2138390/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
