## Packaging review

MUST:
- [Pass] Package must meet Ubuntu versioning & Maintainer requirements
- [Fail] Package must match current Ubuntu (and Debian) packaging policies
    - Missing `Vcs-Git:` and `Vcs-Browser:`
    - Architecture amd64/arm64
    - Multi-Arch field needs to be set
    - d/changelog: update release to stonking
    - d/copyright:
        Upstream-Name: nvidia-mig-manager
        Source: https://github.com/NVIDIA/mig-parted/deployments/systemd
        Should be: https://github.com/NVIDIA/mig-parted, mig-parted
    - template comments left in d/rules
    - consider using conffiles for configuration in /etc/nvidia-mig-manager/

- [Pass] Package must build, install, run, remove, and purge cleanly

SHOULD:
- [Pass] Package should be lintian clean
- [Fail] Contents of debian/ should be sane
  - autopkgtest contains a shell script that prints OK
- [Pass] Changelog should close a "needs-packaging" bug
- [Pass] Package should follow 
http://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html

---

## Maintenance review

MUST:
- [Pass] Package must contain a watch file or get-orig-source rule
    Do we need repacksuffix?
- [n/a] If upstream is no more, the packager should consider adopting the 
upstream package somewhere
- [n/a] Packages who implement get-orig-source for packages with watch files 
get extra points
- [Pass] Packaged version must not have any known security or critical bugs
  https://github.com/NVIDIA/mig-parted/security

SHOULD:
- [Pass] Packaging scripts should be readable and readily comprehensible
- [Pass] Upstream should be responsive, and maintain a bug tracker
    `debian/upstream/metadata` lists 
`https://github.com/NVIDIA/mig-parted/issues`. ✓
- [Fail] Packaged version should be latest upstream
   Version 0.14.1  is the latest
- [n/a] Package should not be native without an approved spec

---

## Suitability review

MUST:
- [Fail] Package must meet copyright / licensing requirements.
    - vendor/github.com/NVIDIA/ and several other vendor dirs, see below:

en: Versions: licenserecon '11.0'  licensecheck '3.3.9-1ubuntu2'

Parsing Source Tree  ....
Reading d/copyright  ....
Running licensecheck ....

d/copyright      | licensecheck

Expat            | BSD-2-clause      vendor/github.com/godbus/dbus/v5/LICENSE
Apache-2.0       | BSD-3-clause      vendor/github.com/NVIDIA/go-nvlib/NOTICE
Expat            | BSD-3-clause      
vendor/github.com/pmezard/go-difflib/LICENSE
Apache-2.0       | BSD-3-clause      
vendor/gopkg.in/evanphx/json-patch.v4/LICENSE
Apache-2.0       | Expat             vendor/gopkg.in/yaml.v2/LICENSE.libyaml
Apache-2.0       | Apache-2.0 and/or Expat vendor/gopkg.in/yaml.v3/LICENSE
Apache-2.0       | Expat             vendor/go.yaml.in/yaml/v2/LICENSE.libyaml
Apache-2.0       | Apache-2.0 and/or Expat vendor/go.yaml.in/yaml/v3/LICENSE
Apache-2.0       | BSD-3-clause      
vendor/k8s.io/apimachinery/third_party/forked/golang/LICENSE
Apache-2.0       | BSD-3-clause      
vendor/k8s.io/kube-openapi/pkg/internal/third_party/go-json-experiment/json/LICENSE
Apache-2.0       | BSD-3-clause      
vendor/k8s.io/utils/internal/third_party/forked/golang/LICENSE
Apache-2.0       | BSD-3-clause and/or Expat vendor/sigs.k8s.io/yaml/LICENSE

- [Pass] Non-native packages must have verifiable cryptographic path to 
upstream source
  Upstream uses signed tags
- [n/a] Package must be advocated by at least two members of ubuntu-dev (the 
packager may count as one).
   First Review

SHOULD:
- [Pass] Package should work on a standard Ubuntu/Kubuntu/Xubuntu/etc. system
- [n/a] Package should provide hints to system services (app-install-data, 
menus, etc.) to ease installation and use
  not a desktop package
- [n/a] Package should provide Ubuntu-specific documentation for variances in 
behaviour from upstream
- [Pass] Package should provide a Homepage: header in debian/control

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2139070

Title:
  [needs-packaging] mig-parted

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+bug/2139070/+subscriptions


-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to