Hello,
This is my review. I'm following this template [0]
* debian/changelog:
* You should target Stonking
* Since composable-kernel is not yet in debian you should only have on entry
in the changelog, and the version should be -0ubuntu1.
* debian/watch:
* it's fine but it's ugly :) Have you tried the github template?
This works better (credits to AI ofc):
* debian/patches
* some patches are missing the Forwarded field
* all patches are missing a description (even so some of them are self
explaining)
* are patches 3 and 5 still required?
* d/control
* standard version can be 4.7.4
* Priority: optional is not required anymore
* d/rules
* the rules files is WILD. Are you sure everything here is required? Can you
add explanation as comments, and remove dead code?
* Why aren't the tests built?
* 'took 2 days, 23 hours, 34 minutes, 28.7 seconds' --> Seriously? I did NOT
build this (: It seems like it does not use the multithreads passed to sbuild?
* d/copyright
* include/rapidjson/msinttypes/inttypes.h is BSD-3-Clause
* include/rapidjson/msinttypes/stdint.h is BSD-3-Clause
* You are missing a lot of copyrights, especially in include/rapidjson. I
haven't checked everything but the regex ^.*Copyright(?!.*Advanced Micro).*$
gives some results.
* Lintian
* source: NOT clean. Please resolve this, don't forget -EvIL +pedantic. Some
can be overriden, some are fixed by things we said already.
* binary: ran against the .deb from your PPA, it's not too bad but please fix
it.
[0] https://wiki.ubuntu.com/UbuntuDevelopment/CodeReviews#NewPackage
[1]
https://git.launchpad.net/~antoinelassagne/+git/libnvidia-container/tree/debian/watch
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2143253
Title:
[needs-packaging] composable-kernel - in ubuntu
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+bug/2143253/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
