** Also affects: wsl-setup (Ubuntu Noble)
   Importance: Undecided
       Status: New

** Also affects: wsl-setup (Ubuntu Questing)
   Importance: Undecided
       Status: New

** Also affects: wsl-setup (Ubuntu Resolute)
   Importance: Undecided
       Status: New

** Also affects: wsl-setup (Ubuntu Stonking)
   Importance: Undecided
       Status: New

** Description changed:

  [ Impact]
  
  With the recent updates to the Ubuntu Desktop terminal theme defined in
  this patch: https://salsa.debian.org/gnome-
  team/ptyxis/-/blob/ubuntu/latest/debian/patches/ubuntu/color-
  palette.patch?ref_type=heads the Windows Terminal profiles for Ubuntu on
  WSL became out of sync. The new colours come with better contrast and
  include a light theme.
  
  We also noticed a small difference in how the terminal icon is rendered
  compared to the Ubuntu website favicon. As the terminal scales down the
  ICO file, it gives us the illusion of loosing one row of orange pixels
  at the bottom. Tests showed that by shipping a smaller version of the
  ICO file (32x32 pixels) we the desired look.
  
  Patches submitted upstream are needed at least to the LTSes we expect to
  build new images as part of their regular lifecycle (Noble and
  Resolute).
  
+ Since new terminal profiles are only created when WSL creates new
+ instances and they never override existing profiles of the same name,
+ the new profile won't cause any change to users with existing instances.
+ Only new setups (after a clean-up if a previous Ubuntu profile existed)
+ can be affected.
+ 
  [ Test Plan ]
  
  On a Windows 11 device with Windows Terminal installed:
  
  - On a preexisting Ubuntu on WSL instance install fastfetch (sudo apt install 
fastfetch)
  - Run fastfatch and record a screenshot for later visual comparison
  - Access the terminal profile of that particular instance (Settings / 
<INSTANCE_NAME> / Appearance)
  - Observe the color values are different from those of ptyxis 
(https://salsa.debian.org/gnome-team/ptyxis/-/blob/ubuntu/latest/debian/patches/ubuntu/color-palette.patch?ref_type=heads).
  - Notice in the color schemes dropdown there is no Ubuntu-Light theme.
  - Still inside the WSL instance, follow the steps in this guide to create a 
chroot environment but do not perform any of the modifications described: 
https://documentation.ubuntu.com/wsl/latest/howto/custom-ubuntu-distro/
- - With the bind-mounts set, chroot into it and install wsl-setup from 
`-proposed` 
+ - With the bind-mounts set, chroot into it and install wsl-setup from 
`-proposed`
  (chroot folder/ && sudo apt update -y && sudo apt install wsl-setup -t 
<release>-proposed)
  - Exit the chroot and pack the directory into a rootfs tarball with the 
command  described in that guide: `sudo tar --numeric-owner --absolute-names 
--one-file-system -czvf ../MyNewUbuntu.tar .` .
  - Move that tarball to the Windows filesystem.
  
  - Remove all existing WSL instances (wsl --unregister <INSTANCE_NAME>)
  - Remove all WSL terminal profiles (on the terminal app go to Settings / 
<INSTANCE_NAME> / "Delete profile")
  
  - Register a new WSL instance from the tarball created above: (wsl --install 
--from-file <TARBALL-LOCATION-ON-WINDOWS> --name MyNewUbuntu)
  - Follow the regular steps and when the shell is available just exit.
  - Close the Windows Terminal
  
  - Reopen the Windows Terminal **and launch the MyNewUbuntu instance from the 
terminal drop down** to see the new theme applied.
  - Install fastfetch (sudo apt install fastfetch)
  - Run fastfetch and compare to the previous screenshot. Colours and font must 
have changed. The icon change is harder to notice, but still noticeable. You 
can compare before (the screenshot) and after (the current state) against the 
favicon of the Ubuntu website as rendered by your favourite browser.
  - Access the terminal profile for that distro in the Windows Terminal 
settings.
  - Compare the colour values against those of ptyxis  
(https://salsa.debian.org/gnome-team/ptyxis/-/blob/ubuntu/latest/debian/patches/ubuntu/color-palette.patch?ref_type=heads).
  - Notice in the color schemes dropdown that now there is the Ubuntu-Light 
theme.
  
  You should notice colours now aligned with ptyxis, the icon position
  looking slightly more centered as well as the existence of a light
  Ubuntu theme. The colour change in both ptyxis and now in WSL are made
  for better accessibility, increasing contrast.
  
  [ Where problems could occur ]
  
  If the colours were not properly selected by our designers, we'd end up in a 
worse condition for accessibility or deviate too much from our branding.
  Desktop designers themselves were the ones pushing the changes in the 
upstream repository. Since new terminal profiles are only created when WSL 
creates new instances and they never override existing profiles of the same 
name, the new profile won't cause any change to users with existing instances. 
Only new setups (after a clean-up if a previous Ubuntu profile existed) can be 
affected.
  
  [ Other Info ]
  
  - https://github.com/ubuntu/wsl-setup/pull/49

** Merge proposal linked:
   
https://code.launchpad.net/~cnihelton/ubuntu/+source/wsl-setup/+git/wsl-setup/+merge/506358

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2156047

Title:
  [SRU] Terminal profile is out of sync with the Desktop theme

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/wsl-setup/+bug/2156047/+subscriptions


-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to