Hi Arif, 1) OVN is a openstack package, and the package git repository lives under the ~ubuntu-openstack-dev repository:
https://git.launchpad.net/~ubuntu-openstack-dev/ubuntu/+source/ovn Please open a MR against this, for the stable/yoga branch. 2) For the debian/changelog, you don't really need to specify the Launchpad bug twice, instead you can do something like the format: * Remove the --restart option in the systemd service to prevent the downed node from remaining on the LRP list even though an outage has occurred. (LP: #2150130) - d/ovn-host.preinst: Do not clear runtime state on package upgrade - d/ovn-host.ovn-controller.service: Remove the --restart option which was leaving records and no cleanups. The first point gives us an idea of what the change does as a whole, and a user who is reading apt changelog can have an idea of what the package does before they install it. 3) I spent a long time figuring out when this change actually happened in Ubuntu. Eventually we came along as discovered that this happened in debian unstable in version 22.12.0-3 which eventually became 23.03.1-1ubuntu0.23.04.1 in Lunar. So all packages from Lunar onward carry this implementation. Please mention this in your SRU template. 4) The Impact statement needs some revision: - What is the real impact to the user? Why is this bad? If we try use the first gateway and fail and then go onto the next one, it still works right? Does this add latency or performance issues or what does the user actually see? - You need to complete the last sentence, about what happens to the runtime state on upgrade. What happens to the runtime state on upgrade, why is it bad? Why do we need the preinstall file to make it all better? 5) The testcase statement needs some revision: - Please add a section on testing the preinstall script to make sure it functions as intended, and avoids the whole clearing of state problem on package upgrade. 6) The Where problems could occur statement needs a revision: - You mention that we don't want to reintroduce bug 1940043, but what steps does your SRU take to ensure this does not happen? - If a regression were to occur, what would it look like to users? How would they know? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2150130 Title: --restart in ovn-controller leaves gateway ports active To manage notifications about this bug go to: https://bugs.launchpad.net/cloud-archive/+bug/2150130/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
