Public bug reported:

[Impact]
The TI TAS2781 smart amp fails to initialize when connected over SPI on the new 
HP HP ZBook.
The right built-in speaker will fail to output after reboot

[Fix]
Two changes in one commit:

1. Always run the software reset sequence for the amp, not just in the
   no-gpio path. This resets device-0 even when its hardware reset pin
   has no effect.

2. Ignore -EXDEV during block processing when the device is on SPI.
   The driver keeps iterating through the blocks and adds up the total
   block size correctly.

Upstream commit (in tiwai/sound for-next, not yet in a released tag):
513480da5e9c ALSA: hda/tas2781: Fix device-0 reset issue and handle
-EXDEV in block data processing

https://patch.msgid.link/[email protected]

[Test Plan]
On HP Zbook with a TAS2781 amp connected over SPI:

$ dmesg | grep -i tas2781

Play audio:
$ speaker-test -c 2 -t wav

Without patch: dmesg shows "dev sw-reset fail" or
"process_block: single write error" / "bulk_write error". No sound
from the TAS2781 speakers.

With patch: no reset or block errors in dmesg. Speakers play sound.

[Where problems could occur]
The reset change now runs the software reset on every path, including
the gpio reset path. If the software reset is wrong for some amp, the
device could fail to come up and stay silent.
Both changes are amp init only, so a regression would show up as no
sound on TAS2781 SPI systems.

** Affects: hwe-next
     Importance: Undecided
         Status: New

** Affects: linux (Ubuntu)
     Importance: Undecided
         Status: New

** Affects: linux-oem-6.17 (Ubuntu)
     Importance: Undecided
         Status: New

** Affects: linux (Ubuntu Noble)
     Importance: Undecided
         Status: New

** Affects: linux-oem-6.17 (Ubuntu Noble)
     Importance: Undecided
         Status: In Progress

** Affects: linux (Ubuntu Resolute)
     Importance: Undecided
         Status: In Progress

** Affects: linux-oem-6.17 (Ubuntu Resolute)
     Importance: Undecided
         Status: New


** Tags: jira-stella-3075 oem-priority stella

** Also affects: linux-oem-6.17 (Ubuntu)
   Importance: Undecided
       Status: New

** Also affects: linux (Ubuntu Noble)
   Importance: Undecided
       Status: New

** Also affects: linux-oem-6.17 (Ubuntu Noble)
   Importance: Undecided
       Status: New

** Also affects: linux (Ubuntu Resolute)
   Importance: Undecided
       Status: New

** Also affects: linux-oem-6.17 (Ubuntu Resolute)
   Importance: Undecided
       Status: New

** Changed in: linux-oem-6.17 (Ubuntu Noble)
       Status: New => In Progress

** Changed in: linux (Ubuntu Resolute)
       Status: New => In Progress

** Tags added: jira-stella-3075 oem-priority stella

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2156556

Title:
  Fix no audio from right built-in speaker on HP ZBook with TAS2781
  amplifier

To manage notifications about this bug go to:
https://bugs.launchpad.net/hwe-next/+bug/2156556/+subscriptions


-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to