Changed from merge to sync as the delta, which addresses a file system
corruption bug when using pmove between devices of different block sizes
(see LP: #1817097), is no longer necessary.


To test this, I built the Debian version of e2fspgrogs in a PPA: 
https://launchpad.net/~chawthorne/+archive/ubuntu/sync-e2fsprogs/+builds?build_text=e2fsprogs&build_state=built

Then, I installed the PPA version in a lxd vm, and followed these steps
(from the discussion on the pmove bug) to reproduce the error:
https://launchpadlibrarian.net/412251462/pvmove-error.txt. Important
part:

# vgextend LOOP_VG /dev/mapper/enc-loop
  Volume group "LOOP_VG" successfully extended

# pvs
  PV                   VG      Fmt  Attr PSize   PFree
  /dev/loop0           LOOP_VG lvm2 a--  496.00m 196.00m
  /dev/mapper/enc-loop LOOP_VG lvm2 a--  492.00m 492.00m

# pvmove -dddddd /dev/loop0 /dev/mapper/enc-loop
  /dev/loop0: Moved: 30.67%
  /dev/loop0: Moved: 100.00%

# pvs
  /dev/LOOP_VG/LV: read failed after 0 of 1024 at 0: Invalid argument
  /dev/LOOP_VG/LV: read failed after 0 of 1024 at 314507264: Invalid argument
  /dev/LOOP_VG/LV: read failed after 0 of 1024 at 314564608: Invalid argument
  /dev/LOOP_VG/LV: read failed after 0 of 1024 at 4096: Invalid argument
  PV                   VG      Fmt  Attr PSize   PFree
  /dev/loop0           LOOP_VG lvm2 a--  496.00m 496.00m
  /dev/mapper/enc-loop LOOP_VG lvm2 a--  492.00m 192.00m


In the newest version of e2fsprogs, mixed block sizes are not allowed by 
default, which is a good sign:

root@e2fsprogs-test:~# vgextend LOOP_VG /dev/mapper/enc-loop
  Devices have inconsistent logical block sizes (512 and 4096).
root@e2fsprogs-test:~# pvs
  PV                   VG      Fmt  Attr PSize   PFree  
  /dev/loop0           LOOP_VG lvm2 a--  496.00m 196.00m
  /dev/mapper/enc-loop         lvm2 ---  484.00m 484.00m
root@e2fsprogs-test:~# pvmove -dddddd /dev/loop0 /dev/mapper/enc-loop
  Physical Volume "/dev/mapper/enc-loop" not found in Volume Group "LOOP_VG".


Running this command while allowing mixed block sizes shows that the bug has 
been addressed:

root@e2fsprogs-test:~# vgextend --config 'devices { allow_mixed_block_sizes=1 
}' LOOP_VG /dev/mapper/enc-loop
  Volume group "LOOP_VG" successfully extended
root@e2fsprogs-test:~# pvs
  PV                   VG      Fmt  Attr PSize   PFree  
  /dev/loop0           LOOP_VG lvm2 a--  496.00m 196.00m
  /dev/mapper/enc-loop LOOP_VG lvm2 a--  480.00m 480.00m
root@e2fsprogs-test:~# pvmove -dddddd /dev/loop0 /dev/mapper/enc-loop
  /dev/loop0: Moved: 21.33%
  /dev/loop0: Moved: 100.00%
root@e2fsprogs-test:~# pvs
  PV                   VG      Fmt  Attr PSize   PFree  
  /dev/loop0           LOOP_VG lvm2 a--  496.00m 496.00m
  /dev/mapper/enc-loop LOOP_VG lvm2 a--  480.00m 180.00m


Lastly, I also confirmed that this version can be upgraded to from the current 
Ubuntu version of e2fsprogs in another vm.


** Summary changed:

- Merge e2fsprogs from Debian for stonking cycle
+ Sync e2fsprogs from Debian for stonking cycle

** Tags removed: dcr-merge
** Tags added: dcr-sync

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2153300

Title:
  Sync e2fsprogs from Debian for stonking cycle

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/e2fsprogs/+bug/2153300/+subscriptions


-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to